Repository navigation
Prep v1.10.1: changelog entry + keep GIF search URLs out of the log - #242
Merged
Merged
Conversation
A failed search logged the whole URLError, whose description embeds the request URL with the search text and the KLIPY API key. Log the error domain and code instead. Refs W-983 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FLzrpi81X78wzfWyPVoM3Q
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FLzrpi81X78wzfWyPVoM3Q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gets
mainready for the next release.Changes
## v1.10.1section covering what's landed since v1.10.0 (Keep the browser grid's top gap when search results scroll #217, Size the browser so the tab bar doesn't leave a sliver #218, W-973: Count unique installs in telemetry (new / weekly / monthly flags) #221, Default symbols to the :: trigger on fresh installs #225, W-990: render the picker glass with public API only #237, Name pasted GIFs mojito-*.gif instead of klipy-*.gif #241).scripts/release.shstops without it. Internal-only changes (CI, README, workers) are left out.URLErroras public. That error's description includes the request URL, so the search text and the KLIPY API key ended up in the system log. It now logs only the error domain and code. (Item 1 of W-983.)Before releasing
stats-workerfirst so the new usage flags from W-973: Count unique installs in telemetry (new / weekly / monthly flags) #221 aren't dropped.Test plan
release.shawk extraction pulls the new section out cleanly.Refs W-983
🤖 Generated with Claude Code
https://claude.ai/code/session_01FLzrpi81X78wzfWyPVoM3Q
Generated by Claude Code