Support @config overrides for extension functions - #1259
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cbf091f3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
@configreplacements for package extension functionsAcceptance criteria
import initlaterconfig dependencies compile without an initialization cycleValidation
./gradlew test --tests tests.wurstscript.tests.ConfigPackageTests— passed after rebasing ontoorigin/master; includes Jass and Lua execution./gradlew test— passed after rebasing ontoorigin/masterin 3m 55sgit diff --check— passedKnown gaps
codefunction references cannot target extension functions because their implicit receiver counts as a parameter; that pre-existing language restriction is unchanged.