Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Report on HTTP Status with descriptive string - #182

Open
asanghi wants to merge 2 commits into
wvanbergen:masterfrom
asanghi:httpstatusstring
Open

Report on HTTP Status with descriptive string#182
asanghi wants to merge 2 commits into
wvanbergen:masterfrom
asanghi:httpstatusstring

Conversation

@asanghi

@asanghi asanghi commented Mar 18, 2015

Copy link
Copy Markdown
Contributor

Currently the report gives a frequency of "200" or "406" or whatever. Some HTTP Codes are obscure and are always a bit hard to remember. This change request ensure that they get aggregated and reported as "200 OK" or "404 Not Found" etc.

instead of just the integer code
@asanghi

asanghi commented Mar 23, 2015

Copy link
Copy Markdown
Contributor Author

@wvanbergen What do you think?

Comment thread lib/request_log_analyzer/version.rb Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't update the VERSION constant - this is done as part of the release process.

@wvanbergen

Copy link
Copy Markdown
Owner

Just a small nitpick, this looks good to me.
Don't worry about the tests; this seems to be an ActiveRecord compatibility issue.

@asanghi

asanghi commented Mar 31, 2015

Copy link
Copy Markdown
Contributor Author

No worries. Seems like I misread the contribution instructions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants