Repository navigation
Conversation
vmarkop
marked this pull request as ready for review
July 8, 2026 08:27
vmarkop
force-pushed
the
feat/attestation-based-client-authentication
branch
from
October 14, 2026 10:44
227101b to
259f82a
Compare
vmarkop
force-pushed
the
feat/attestation-based-client-authentication
branch
from
October 14, 2026 10:52
259f82a to
bb0f035
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds OAuth 2.0 Attestation-Based Client Authentication (ABCA) to wallet-as, with optional WE BUILD profile checks.
Changes:
OID4VC_PROFILEenv param with valuesDEFAULTorWEBUILD.Configuration required
Deployment requires
ABCA_CHALLENGE_SECRET: a shared 64-character hexadecimal secret across AS replicas. wwWallet/wwwallet#71 brings this variable to your local installation. WEBUILD additionally requires WEBUILD_ABCA_STATUS_LIST_ALLOWED_ORIGINS.This PR changes the wallet client
1233in oauth2clients.json to useattest_jwt_client_authas atoken_endpoint_auth_method. Ensure you add that auth method to clients you would like to use ABCA for, or remove it if you do not want to use it.Configuration and profile behavior are also documented in the README and environment template.
Manual verification: complete issuance with an ABCA-capable wallet under DEFAULT, then enable WEBUILD and verify that valid attestations succeed while revoked status or mismatched DPoP keys are rejected. Ensure that local issuance works both with a client using
attest_jwt_client_authand with a non-abca client.