Repository navigation
fix(format): exclude JS/TS from editorconfig-checker - #1215
Merged
Merged
Conversation
gsiou
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1197. Prettier with tabs puts spaces after the tabs in some lines to line code up (for example the closing brace of an object type inside a union), and editorconfig-checker reports these lines as wrong indentation. Prettier has no option to turn this off.
#1197 unset
indent_stylefor JS/TS in.editorconfig. That also made Prettier fall back to spaces, so it needed auseTabsoverride to restore tabs. This PR replaces that workaround:.editorconfig: remove the[*.{js,ts,tsx}] indent_style = unsetsection. Prettier and editors get tabs from[*]again..prettierrc.yaml: remove theuseTabsoverride, which is no longer needed..editorconfig-checker.json: exclude.js,.tsand.tsxfiles. Prettier checks these files, and editorconfig-checker keeps covering the rest (JSON, Dockerfiles, nginx config, shell scripts and so on).No file is reformatted.
Testing
yarn format:checkpasses.pre-commit run editorconfig-checker --all-filespasses.Before submitting