Repository navigation
test: construct scheduling policies without instance registry - #19
Merged
Merged
Conversation
Upcoming proxy refactors stop injecting the instance registry into scheduling policies: RoundRobinSchedulingPolicy no longer accepts a registry argument and LoadBalancedScheduler takes the model lengths as data instead of querying the backend. Make the integration tests tolerant of both API versions so the suite stays green against current main and against the refactored proxy. Signed-off-by: hlin99 <tony.lin@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with xPyD-hub/xPyD-proxy#198.
Summary
RoundRobinSchedulingPolicyis constructed without the instance registry (the refactored proxy no longer injects it).LoadBalancedScheduleris built through a small helper that injects model lengths when the proxy supports it and falls back to the legacy backend query otherwise.The helper keeps the suite green against both the current proxy main and the refactored branch, so this PR can land independently.
Validation
pyteston the three affected files against proxyrefactor/scheduler-policy-boundaries: 38 passedmain: 38 passedruff check: passed