[prototype] feat(huntsman): Support input sharing across input tasks. - #490
Draft
LinZhihao-723 wants to merge 2 commits into
Draft
LinZhihao-723 wants to merge 2 commits into
LinZhihao-723 wants to merge 2 commits into
Conversation
…ared input payloads. * Add `TaskGraphInput` and `TaskGraphInputBuilder` in a new `task_graph_input` submodule of `spider_core::types::io`, where each positional input is either a value payload or a reference to a shared input payload serialized once. * Add zstd-compressed serialization and validated deserialization for `TaskGraphInput`. * Add `into_positional_inputs` to resolve positional inputs while creating each shared input payload only once. * Add `WireFrameBuilder::with_prefix`, `WireFrameBuilder::append_payload_parts`, and `WireFrameBuilder::unframe_payload_slices` to `spider-utils` wire framing.
…TaskGraphInput` with shared input payloads: * Change `SpiderClient::submit_job` to accept a `TaskGraphInput` instead of a `Vec<TaskInput>`. * Make `ValidatedJobSubmission` hold the deserialized `TaskGraphInput` and validate the number of positional inputs against the number of task graph inputs. * Materialize each shared input payload into a single cache dataflow slot shared by every positional input referencing it. * Add an end-to-end neural-network test where all first-layer neurons share the same inputs.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Open
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Warning
Please do no merge this PR!
This is a prototype that implements #489.
Checklist
breaking change.
Validation performed