Skip to content

test(e2e): cover the Brand DNA AI key panel - #339

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
Ghifariezra:chore/e2e-brand-dna-key-panel
Oct 21, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
Ghifariezra:chore/e2e-brand-dna-key-panel

Conversation

@Ghifariezra

Copy link
Copy Markdown
Contributor

Summary

Adds an e2e test for the Brand DNA AI key panel, with every request to api.anthropic.com blocked so nothing can leave the browser.

The test:

  • saves a key and checks it is stored unreviewed (read straight from IndexedDB)
  • checks the review shows the downscaled image and that no provider request has been made yet
  • approves the review and checks the consent is stored
  • removes the key and checks the stored record is gone

Closes #334

Screenshots

Not applicable, test-only change.

Checklist

  • pnpm typecheck, pnpm test, pnpm lint, pnpm check:dashes and pnpm build pass
  • Conventional commit messages (feat:, fix:, docs:, chore:)
  • Tested in dark and light themes and at mobile width (375 px)
  • Works with keyboard only
  • No any, no console.log, no new external services without a note in .env.example
  • Docs and CHANGELOG.md updated if behavior changed

Breaking changes

None.

Testing completed

  • pnpm typecheck, pnpm test (1712 passed), pnpm lint, pnpm format:check and pnpm build pass locally.
  • pnpm test:e2e: 53 passed, including the new spec.
  • pnpm check:dashes reports em dashes only inside packages/cli/node_modules/vite, none in files changed by this PR.

@Ghifariezra
Ghifariezra requested a review from yakew7 as a code owner October 21, 2026 06:41
@vercel

vercel Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@Ghifariezra is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Hi @Ghifariezra, welcome to DesignHub and thanks for your first pull request! 🎉

DesignHub is an open-source, local-first design and brand toolkit that runs entirely in the browser: set up a brand once and get logo variants, mockups, social media assets, a brand guidelines PDF and design tokens, plus typography, color, icon, background, effects, SVG and accessibility tools. No login, no backend, no API keys.

A maintainer will review this soon. Meanwhile, please check that pnpm typecheck && pnpm lint && pnpm format:check && pnpm build pass and that the PR template checklist is filled in.

If you like the project, a ⭐ on the repository helps other people find it.

Feel free to contribute more! Issues labeled good first issue and help wanted come with step-by-step instructions, and CONTRIBUTING.md has the setup and style guide. Questions are always welcome in the comments.

@yakew7
yakew7 merged commit 148e8c3 into yakew7:main Oct 21, 2026
8 of 9 checks passed
@Ghifariezra
Ghifariezra deleted the chore/e2e-brand-dna-key-panel branch October 21, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing: Playwright test for the Brand DNA key panel

2 participants