Repository navigation
Reword the benchmark override warning for the lifted paper freeze (#1… - #1057
Merged
yakew7 merged 1 commit intoOct 18, 2026
Merged
Conversation
…kew7#1048) The paper freeze is lifted and results/ is expected to change, but the benchmark command still warned that a non-default --n-resamples/ --n-permutations 'will not match the frozen paper reference', pointing contributors at a protected reference that no longer applies. Reword the warning to say the value differs from the default (2000), so the numbers will not match the published results in results/ or the reference snapshot in paper/results-frozen/. Updates the test that asserts the old text.
Contributor
|
@sammist2 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1048.
The paper freeze is lifted (see CLAUDE.md) and
results/is expected to move again, butfaircode benchmarkstill warned that a non-default--n-resamples/--n-permutations"will not match the frozen paper reference" — pointing contributors at a protected reference that no longer applies.The warning now says the value differs from the default (2000), so the numbers will not match the published results in
results/or the reference snapshot inpaper/results-frozen/. The test that asserted the old text is updated to match.