Repository navigation
fix(mcp): proxy_hints says in notes why an empty hints list is empty (#1044) - #1058
Merged
yakew7 merged 1 commit intoOct 18, 2026
Merged
Conversation
…akew7#1044) Signed-off-by: minutechreview <141821420+minutechreview@users.noreply.github.com>
Contributor
|
@minutechreview is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP
proxy_hintstool returned{"hints": []}both when every pair was tested and none was significant, and when the dataset had fewer than two dimensions so no pair could be tested. #1022 fixed this in the terminal and HTML reports; the MCP result still did not say which it was.When
hintsis empty,_proxy_hints_implnow adds one entry tonotes, using_no_hints_textfromfaircode/report.pyso the words match the reports:none tested: a pair needs at least two dimensions (found N)when fewer than two dimensions existnone found: no pair of dimensions is significantly associatedotherwiseA column given through
held_out_withis compared with every dimension, so it counts toward the two a pair needs. A result with at least one hint has no such note.faircode/SPEC.mdsection 11 describes it.Tests in
tests/test_mcp_server.pycover one dimension, two independent dimensions, and a result with a hint (no note).Type
Linked issue
Closes #1044
Checks:
pytest tests -m "not slow" --ignore=tests/browsergives 907 passed, 19 skipped.ruff check faircode tests scriptsandscripts/check_em_dash.pypass. The new one-dimension test fails if the note is removed. I did not run the slow benchmark tests or the browser tests.