Skip to content

fix(mcp): proxy_hints says in notes why an empty hints list is empty (#1044) - #1058

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
minutechreview:fix/mcp-proxy-hints-empty-note-1044
Oct 18, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
minutechreview:fix/mcp-proxy-hints-empty-note-1044

Conversation

@minutechreview

@minutechreview minutechreview commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The MCP proxy_hints tool returned {"hints": []} both when every pair was tested and none was significant, and when the dataset had fewer than two dimensions so no pair could be tested. #1022 fixed this in the terminal and HTML reports; the MCP result still did not say which it was.

When hints is empty, _proxy_hints_impl now adds one entry to notes, using _no_hints_text from faircode/report.py so the words match the reports:

  • none tested: a pair needs at least two dimensions (found N) when fewer than two dimensions exist
  • none found: no pair of dimensions is significantly associated otherwise

A column given through held_out_with is compared with every dimension, so it counts toward the two a pair needs. A result with at least one hint has no such note. faircode/SPEC.md section 11 describes it.

Tests in tests/test_mcp_server.py cover one dimension, two independent dimensions, and a result with a hint (no note).

Type

  • Bug fix

Linked issue

Closes #1044

Checks: pytest tests -m "not slow" --ignore=tests/browser gives 907 passed, 19 skipped. ruff check faircode tests scripts and scripts/check_em_dash.py pass. The new one-dimension test fails if the note is removed. I did not run the slow benchmark tests or the browser tests.

…akew7#1044)

Signed-off-by: minutechreview <141821420+minutechreview@users.noreply.github.com>
@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

@minutechreview is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit 5a2edba into yakew7:main Oct 18, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The MCP proxy_hints tool returns just {"hints": []} for a dataset with one dimension, with no note that nothing was tested

2 participants