Repository navigation
ci: add job timeouts and PR concurrency to every workflow (#1050) - #1059
Merged
yakew7 merged 1 commit intoOct 18, 2026
Merged
Conversation
Every job now sets timeout-minutes (5 to 30, recent runs finish in under five minutes), and workflows that run on pull_request cancel superseded PR runs via a concurrency group. Runs on main are never cancelled. The policy is written up in .github/ACTIONS-AUDIT.md.
Contributor
|
@AnayDhawan is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
timeout-minutesto every workflow job and aconcurrencygroup to every workflow that runs onpull_request, and write the policy up in.github/ACTIONS-AUDIT.md.Type
Audit checklist
N/A, this PR is not an audit.
Explainer checklist
N/A, this PR is not an explainer.
Details
timeout-minutes: 5 for the small check jobs, 10 for lint, favicons, explainers and browser smoke, 15 for the audit matrix, 20 for the profiler tests, 30 for the benchmark harness and CodeQL. Recent runs finish in under 5 minutes end to end, so the limits leave a wide margin.concurrency: group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}.cancel-in-progressis${{ github.event_name == 'pull_request' }}, so a new commit cancels the stale PR run but a push tomainor a scheduled run is never cancelled.first.interaction.ymlandpr-review-ping.ymlare left withoutconcurrency: they run onissues/pull_request_targetand post one-off comments, which a cancel would drop.pushandpull_request, so a commit on a branch with an open PR starts those jobs twice. Restrictingpushtomainwould fix that but changes which events gate a merge, so I left it as a separate decision. Noted inACTIONS-AUDIT.md.Testing
timeout-minutes, andconcurrencyis present on the 10 expected workflows.python scripts/check_em_dash.pypasses.Linked issue
Closes #1050