Repository navigation
Conversation
proxy_hints compares pairs of dimensions, so a dataset with fewer than
two testable dimensions has no pair to test and returns {"hints": []}.
With no explanation an agent can read that as "tested, found nothing"
rather than "nothing could be tested."
_proxy_hints_impl now adds a 'notes' entry naming the testable
dimensions and stating that at least two are needed, when the empty
result is due to there being fewer than two. A dataset that does have a
pair to test is unaffected. Adds a regression test.
Contributor
|
@sammist2 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
@sammist2 Fix merge Conflicts and CI Fails pls |
Contributor
Author
|
Closing this — #1044 has since been resolved on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1044.
The MCP
proxy_hintstool compares pairs of dimensions, so a dataset with fewer than two testable dimensions has no pair to test and returns{"hints": []}with nothing to say whether it tested and found nothing or had nothing to test._proxy_hints_implnow adds anotesentry naming the testable dimensions and stating that at least two are needed, when the empty result is due to there being fewer than two. A dataset with a real pair to test is unaffected. Adds a regression test intests/test_mcp_server.py.