Repository navigation
fix(ci): run extracted findings effect in frontend test harness - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failure
The
mainCI run 40367112722 failed on two frontend scan-detail findings retry tests, while backend and Windows jobs passed.Root cause
The test harness uses
new Function(...)to construct a closure for the extracted React effect, but returnedrunEffectinstead of invoking it. Thus the assertions ran against initial values without the effect executing.Fix
Return
runEffect()so the test receives the effect cleanup function and actually exercises retries and successful loading. Production UI code and CI gates are unchanged.Validation
Wait for frontend unit tests, typechecking, lint, build, and backend/Windows checks to pass on this PR before merging.