Repository navigation
fix(ci): align change-analysis missing artifact test with null sentinel - #4
Merged
yashaskn8 merged 1 commit intoOct 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failure
The post-merge
mainCI run 40375825350 introduced a separate failure infrontend/tests/change-detail-artifact-recovery.test.mjs, added on a concurrentmaincommit. The test expected missingdiffandreviewartifacts to remainundefined, but the normal initial loading effect explicitly resets the state tonull.Change
Assert
nullinstead, which correctly means unknown/unavailable, not a verified empty result. Add a comment explaining that distinction. Production UI code and CI gates remain unchanged.Validation
Require passing frontend tests, typecheck, lint and build, and all backend and Windows checks before merging.