Repository navigation
Add opt-in bounded wake diagnostics - #136
Open
simeszi001 wants to merge 1 commit into
Open
simeszi001 wants to merge 1 commit into
simeszi001 wants to merge 1 commit into
Conversation
Owner
|
this is definitely interesting, most if not all of this pr belongs in the library itself, not in echolocal, as it is device agnostic. that will remove the need for the go changes. Also recommend using |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unexpected activations are difficult to attribute from wake logs alone. This adds opt-in, bounded local diagnostics that correlate model crossings with microphone/model settings and distinguish button/API requests and follow-ups.
Depends on ygelfand/libcountertop#2. Merge the library change first. For reproducible review builds this branch pins the public library fork to its immutable PR commit; replace that temporary remote dependency with the merged upstream version before merging this PR. There is no local filesystem
replaceor dependency on a developer's checkout.Behavior
The English guide documents API arguments, base64 page reconstruction, hash verification, consent, access boundaries, retention and diagnostic limitations. Recording expiry does not delete saved clips. Authenticated clients can explicitly retrieve audio; there is no automatic cloud upload. No raw household recordings, device addresses, room bindings, credentials, deployment helpers, firmware version overrides or listener-policy changes are included.
Validation
go test ./...,go vet ./..., andgo test -race ./...board_biscuit) builds, plus ARM/noasmboard_biscuitlintAn earlier downstream variant was exercised on seven Echo Dot 2 devices; this cleaned-up PR revision has not been flashed or acoustically retested. The current evidence is automated testing and cross-compilation, not a claim of improved wake accuracy. Android NDK/Show payload builds were not run locally; those remain for upstream CI/hardware coverage.