-
-
Notifications
You must be signed in to change notification settings - Fork 49
Performance optimizations #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samdark
wants to merge
18
commits into
master
Choose a base branch
from
performance
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9a2aec8
Add benchmark with typical usage pattern
samdark 694978e
Introduce composite container lookup cache
samdark f9b88a6
Introduce cache for `has()`
samdark f1e6568
Fast path for empty definition validation
samdark 209ce3a
More benchmarks
samdark 63e5e2c
Use try-catch instead of has() and then get()
samdark a9818c3
Call `DefinitionParser::parse` only if definition is an array
samdark 10ec99d
Inline addDefinition()
samdark c6dcb5c
Batch-prepare definitions
samdark a77213d
Add fast path for empty delegates
samdark 423766a
Use separate code branches for preps with/without validation
samdark 28dbc96
Fix edge cases
samdark ae231b5
Apply PHP CS Fixer and Rector changes (CI)
samdark 821c585
Raise code coverage
samdark 3da230f
Cap has() cache to avoid using too much memory
samdark ff3830d
Apply PHP CS Fixer and Rector changes (CI)
samdark 7ff3356
Make cache cap configurable, add README
samdark cc81a0a
Apply PHP CS Fixer and Rector changes (CI)
samdark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.