Skip to content

CI checks and CLAUDE.md trim - #1

Draft
yobazy wants to merge 1 commit into
mainfrom
ci-checks
Draft

yobazy wants to merge 1 commit into
mainfrom
ci-checks

Conversation

@yobazy

@yobazy yobazy commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Risk: high. Adds CI config (GitHub Actions). Look closely at: .github/workflows/ci.yml

What changed

New workflow .github/workflows/ci.yml, one job on ubuntu-latest with Node 24 and npm cache. Runs on PRs to any branch and pushes to main, skips Markdown-only changes, cancels superseded runs, 15 minute timeout, read-only permissions, no secrets.

Checks it runs:

  1. npm ci (from package-lock.json)
  2. npm run lint (oxlint with .oxlintrc.json)
  3. npm run build (tsc -b type check, then vite build)

CLAUDE.md

No tracked CLAUDE.md, AGENTS.md or .claude/ files in the repo, so part B was skipped. No files changed.

Skipped and why

  • Tests: the repo has no test runner or test files.
  • npm run screenshots: needs Playwright browsers and a dev server; it regenerates docs images and is not a check.
  • Node version: no .nvmrc or engines; picked Node 24 (current LTS, the version used locally). Vite 8 needs ^20.19 || >=22.12.

How to check

npm ci && npm run lint && npm run build locally; all three pass on a clean checkout. The PR's own CI run is the proof.

Needs Bazil

  1. Optional: add an engines field or .nvmrc if you want a different Node version pinned.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yobazy

yobazy commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Review (second session, fresh context)

Nothing to fix. The PR does what the brief asked and the check is real.

What I checked

  • Diff against origin/main: one file, .github/workflows/ci.yml (39 lines). No other changes, no secrets, no tokens, no personal data.
  • Workflow against the brief: pull_request plus push to main, paths-ignore: '**/*.md' on both, concurrency with cancel-in-progress: true, permissions: contents: read, timeout-minutes: 15, ubuntu-latest, actions/checkout@v4, actions/setup-node@v4 with cache: npm, one job, no matrix, no schedule, no deploy, no artifacts.
  • Clean install, lint and build in the worktree (Node v24.22.1):
    $ npm ci
    added 37 packages, and audited 38 packages in 2s
    $ npm run lint
    > oxlint
    (exit 0, no findings)
    $ npm run build
    > tsc -b && vite build
    ✓ 2015 modules transformed.
    ✓ built in 228ms
    
    tsc -b is a real type check here (noEmit: true in tsconfig.app.json). The worktree was clean afterwards.
  • The PR's check, on the current head ead2bd8:
    $ gh pr checks 1
    check	pass	13s	https://github.com/yobazy/expecta-cursor-hackathon/actions/runs/43399354868/job/131798034296
    
    Steps Install, Lint and Type check and build all finished with success.
  • Part B: git ls-files shows no CLAUDE.md, AGENTS.md or .claude/ on this branch or on main, so skipping it was right.
  • No tests were skipped or removed. The repo has none.
  • Risk: high in the PR body is correct for CI config.

What I fixed

Nothing. No commits from the review.

Left for Bazil

  1. Read .github/workflows/ci.yml and mark the PR ready if you're happy with it.
  2. A PR that only touches Markdown gets no check at all (that is what paths-ignore does). Fine today. If you later make check a required status in branch protection, those PRs would wait forever, so drop paths-ignore at that point.
  3. The run shows a warning that actions/checkout@v4 and actions/setup-node@v4 target Node 20 and are forced onto Node 24. It works now. Bumping both to their newer majors clears it. The brief asked for v4, so I left them.
  4. npm ci reports 4 vulnerabilities (1 moderate, 3 high). All are in dev tooling: npm audit --omit=dev says found 0 vulnerabilities. Not part of this PR.
  5. Node 24 is the run's pick because the repo has no .nvmrc or engines. Add one if you want a different version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant