Skip to content

Give a project's lead its own window, and tidy the project card - #219

Merged
yobazy merged 2 commits into
mainfrom
project-lead-settings
Nov 12, 2026
Merged

yobazy merged 2 commits into
mainfrom
project-lead-settings

Conversation

@yobazy

@yobazy yobazy commented Nov 12, 2026

Copy link
Copy Markdown
Owner

The project card was crowded and hard to find things in, and the lead lived inside it. Now:

  • Lead… window (new LeadDialog.tsx). It opens from the project's right-click menu, a one-line pointer on the card, "Lead settings" in the lead's chat header (this replaces the Personality popover) and Settings › Leads.
    • Sections: What it may do (four level cards, arrow keys), Personality (pet, personality, instructions), and Model and notes.
    • Level and pet can be picked before the lead starts (startProjectLead takes them).
    • A new model on a running lead waits for "Restart on X". Restart and Remove confirm inline, with focus on Keep it.
    • Escape and Tab stay inside the window. Opening a chat or thread from it also closes a card under it, with a flash if card edits were dropped.
  • Project card is grouped into What lives here / How tasks run / Home. "Isolated / Shared" now reads "Own worktree / Main checkout", and RouteReview matches. The router prompt is unchanged.
  • Settings › Leads tab, moved out of General:
    • One row per project lead: pet, state, level, Edit….
    • Add a lead… opens a menu of projects without one.
    • Then the top lead (Remove confirms now) and How tasks ask a lead.
    • Search finds the rows by lead project names and personality, instructions and pet.

Built over three review rounds, each with a fresh read-only reviewer; every finding was fixed or declined. One was declined: the top lead still edits inline rather than in a window.

Checks: npm run build and npm test pass (619). No Rust changed. Every flow was driven by Playwright scripts against the npm run dev browser mock: menu, card, chat, Settings, confirms, Escape, the Tab trap, focus return and search. It hasn't been tried in the sandbox app or on a real lead start or restart.

🤖 Generated with Claude Code

yobazy and others added 2 commits November 12, 2026 15:49
The lead moves out of the project card into a Lead… window, opened from the
project's menu, a line on the card, the lead's chat and Settings › Leads. It
shows what the lead may do as four level cards, its pet, personality and
instructions, and its model and notes. Level and pet can be picked before it
starts; a new model on a running lead waits for Restart; Restart and Remove
ask first.

The card is grouped into What lives here, How tasks run and Home, and says
"Own worktree" / "Main checkout". Settings gets a Leads tab: one row per
project lead with its level and Edit…, Add a lead…, the top lead, and how
tasks ask a lead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yobazy

yobazy commented Nov 12, 2026

Copy link
Copy Markdown
Owner Author

Review done; no blocking issues found. Writing it up.

Passes: the lead's own window and the regrouped project card look correct, and CI passes.

  • src/components/LeadDialog.tsx:141: the window listens for Escape before anything else and stops it there, so Escape closes only the lead window. The project card, chat and Settings each listen later and never see it.
  • src/nebula/leadRunner.ts:221: the new optional level/pet only apply to a lead's first start. A restart still keeps the lead's saved level and pet.
  • src/components/LeadDialog.tsx:152: starting a lead now builds on the saved card (or a draft from the project's files) instead of the card form's unsaved edits. The form reads the lead back when it saves, so nothing is lost.
  • src/components/CardDialog.tsx:284: the checks box now hides when "Check finished work" is off. That matches reviewRunner.ts:68, which skips checks and the reviewer together when it's off.
  • No protocol, types.ts, Rust, version or latest.json changes, and no earlier comments or reviews on the PR.

VERDICT: PASS

@yobazy
yobazy merged commit 49b3048 into main Nov 12, 2026
1 of 2 checks passed
@yobazy
yobazy deleted the project-lead-settings branch November 12, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant