Skip to content

CI checks and CLAUDE.md trim - #222

Draft
yobazy wants to merge 2 commits into
mainfrom
ci-checks
Draft

yobazy wants to merge 2 commits into
mainfrom
ci-checks

Conversation

@yobazy

@yobazy yobazy commented Nov 13, 2026

Copy link
Copy Markdown
Owner

Risk: high. It changes CI config. Look closely at: .github/workflows/ci.yml

What changed

CI (.github/workflows/ci.yml). CI already ran every check on each PR and on pushes to main, so I didn't add a second workflow. The one change: timeout-minutes: 15 on the check job, so a hung run stops. The longest of the last 100 green runs took 7 minutes, and most take about 3.

The check job (macos-latest, unchanged) runs:

  • npm ci
  • npm run build: tsc, then vite
  • npm test: 628 Node tests
  • cargo fmt --check
  • cargo clippy --all-targets --locked -- -D warnings
  • cargo test --locked

It stays on macOS because the app only builds there (rust-toolchain.toml targets apple-darwin only). The repo is public, so macOS minutes are free.

CLAUDE.md went from 55 lines to 54. I ran a prompt audit against Claude Opus 5.5 and checked every path and command the file names against the scripts and code. All of them are still accurate. The file has no all-caps emphasis, no IMPORTANT/NEVER markers and no booster phrases. The only finding was the opening lines, which described the stack and folder layout that the code already shows. They now just say what's worth opening README.md and CONTRIBUTING.md for. Every rule and safety line is kept.

Skipped

  • paths-ignore: **/*.md: left out. With it, a PR that only changes Markdown would get no check run. The reviewer agent merges once checks pass, and if check is a required status, a docs-only PR would wait forever. I couldn't read the branch protection settings from this run to check.
  • Other instruction files: tests/fixtures/**/CLAUDE.md and SKILL.md are test data for the app's parsers, so I didn't touch them. I didn't edit .claude/settings.json or the hooks either: they're config, not instructions.

How to check

  • The check run on this PR goes green.
  • Locally: npm run build && npm test, then cd src-tauri && cargo fmt --check && cargo clippy --all-targets --locked -- -D warnings && cargo test --locked.

Needs Bazil

  1. Should Markdown-only PRs skip CI (paths-ignore)? Only if check isn't a required status and the reviewer agent treats "no checks" as passing.

🤖 Generated with Claude Code

yobazy and others added 2 commits November 13, 2026 02:57
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@yobazy

yobazy commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Checks are green: CI #222, check passed in 2m12s (run 43389592386).

One more for Needs Bazil: GitHub warns that actions/checkout@v4 and actions/setup-node@v4 run on deprecated Node 20. Moving them to v5 clears the warning. For now it's only a warning, and the check passes.

@yobazy

yobazy commented Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Review (fresh session, Fable 5.2): pass, nothing to fix

What I checked

  • Full diff, git diff origin/main...HEAD: 2 files, +4 -3. One timeout-minutes: 15 line plus a comment in .github/workflows/ci.yml, and the opening lines of CLAUDE.md. Nothing outside the brief, no secrets or personal data, no tests touched.
  • npm run build: ✓ built in 532ms (tsc clean).
  • npm test: ℹ tests 628 / ℹ pass 628 / ℹ fail 0 / ℹ skipped 0.
  • cargo fmt --check --manifest-path src-tauri/Cargo.toml: no output, exit 0.
  • gh pr checks 222: check pass 2m12s. That run (43389592386) is on the head commit 6136993, so clippy and cargo test ran on macOS against exactly this code. I did not run them on the PC: the crate only builds for macOS.
  • The 15 minute limit is safe. It counts job time, not queue time. The two slowest green runs of the last 100 (1111s and 470s end to end) were waiting for a runner: their check jobs ran 2m28s and 2m41s. Runs right after a Cargo.lock change took under 5 minutes end to end (278s, 203s).
  • Every script and command CLAUDE.md names still exists: scripts/sandbox.sh app|up|down|e2e, scripts/drive (select, open, click, type, key, text, shot, replay, run), scripts/pc up|drive, the nebula tag pin in src-tauri/Cargo.toml, latest.json written by scripts/release.sh. The new opening line matches README's sections (sandbox, Version pinning, Releasing) and CONTRIBUTING's Pull requests section.
  • The other two CLAUDE.md files are under tests/fixtures/ and are read by tests/cards.test.mjs. Leaving them alone was right.
  • Risk: high is on the first line of the body and is the right level.

What I fixed

Nothing. No commits from me.

Left for Bazil

  1. paths-ignore for Markdown: keep it out. gh pr checks 222 --required lists check, so it is a required status on main. With paths-ignore, a docs-only PR would get no check run and could never merge. This answers the question in the PR body; no action needed unless you want to change the branch rule.
  2. Small wording slip in the PR body: "the longest of the last 100 green runs took 7 minutes" is queue time plus run time, and one run was 18.5 minutes that way. Actual job time has stayed under 5 minutes, so the conclusion holds. I left the body as is.
  3. actions/checkout and actions/setup-node at v4 show GitHub's Node 20 deprecation warning. It is only a warning today. Bump both to the next major when you want it gone; the brief pinned v4, so it stayed.
  4. The CLAUDE.md trim is three lines because the file was already lean (55 to 54 lines). I read it against the brief's list and found nothing else worth cutting.
  5. I could not read the branch protection settings directly (gh api is blocked in these runs), so item 1 rests on gh pr checks --required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant