Repository navigation
docs(release): sync the fdroiddata recipe snapshot to v1.2.28 - #410
Merged
Merged
Conversation
The MR branch now pins v1.2.28 (versionCode 67, commit 4a662c4) and the NonFreeNet reason also names the Codex binary download and the ChatGPT/OpenAI sign-in. The snapshot is byte-identical to the recipe that passed the fork pipeline, including the reproducible-build comparison against the published -fdroid-release.apk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync the fdroiddata recipe snapshot in
docs/RELEASE.mdto the branch of MR !48005 after v1.2.28 (same follow-up as #367 did for v1.2.27).versionName1.2.28 /versionCode67 / commit4a662c4a9b69f7c876bb32193c101c70536f0d25(the v1.2.28 release commit),CurrentVersion1.2.28 / 67.soccer.hy620/fdroiddata, commit190a8c916).Docs only: one file, no code or resource changes.
Verification
fdroid buildcompared the built binary to the publishedand-code-v1.2.28-fdroid-release.apkand it matched; the APK's signer is the allowed key.git rev-parse v1.2.28^{commit}equals the recipe'scommit;versionCode = 67/versionName = "1.2.28"at that commit../gradlew detekt spotlessChecknot run: spotless targets only*.kt/*.gradle.kts, and this change touches neither.Review notes
The
repo-revieweragent type does not exist in this Claude Code environment, so the review below was run by a general-purpose subagent instructed to follow.opencode/agents/repo-reviewer.mdexactly (read-only, same output format). It returned APPROVE with no blockers and no suggestions to apply. Its one caveat (it could not see the fork CI result, being offline) is covered by the Verification section above.Pre-PR review
判定: APPROVE
ブロッカー
なし
提案(非ブロッキング)
チェック済み項目
git fetch origin main --tags後にgit diff origin/main...HEADを確認した。変更はdocs/RELEASE.mdの1ファイルのみ(+9/-8)。ブランチはorigin/main(5a1c7551)の直上の1コミット(0812df23)で、merge-base も origin/main と一致する。docs/RELEASE.mdの ```yaml ブロック(59行)を awk で抽出し、fork のfdroiddata-fork/metadata/com.yugahashimoto.andcode.ymlと `diff` / `cmp` で比較した。差分なしで完全一致(末尾改行や `Binaries: ` の行末空白も含む)。fork の HEAD は `190a8c916 AndCode: update to v1.2.28 and cover Codex in the NonFreeNet reason` で、作業ツリーは clean。fdroid rewritemeta、lint、reproducible-build 比較)の実行結果そのもの。このレビューはネットワーク/gh を使わない read-only 制約のため、確認できていない。レシピが fork の HEAD と一致することだけを確認した。.release-versionはv1.2.28。git show 4a662c4a:app/build.gradle.ktsはversionCode = 67、versionName = "1.2.28"。git rev-parse v1.2.28^{commit}は4a662c4a9b69f7c876bb32193c101c70536f0d25で、レシピの commit と一致する。このコミットは origin/main の祖先(PR chore(release): v1.2.28 #407chore/release-1.2.28のマージコミット)。Builds:の versionName/versionCode/commit とCurrentVersion: 1.2.28/CurrentVersionCode: 67もすべて一致する。1.2.27、v1.2.27、db8ed2e8、versionCode: 66/CurrentVersionCode: 66はいずれも0件。docs/RELEASE.md130行の「snapshot ... (v1.2.28)」は更新済み。レシピ下の説明(rewritemetaの順序、AllowedAPKSigningKeys、Binaries:の-fdroid-release.apk)は今回の変更に影響されず、引き続き正しい。NonFreeNet の文言や旧バージョンに触れる記述は他にない。release.ymlのコメントにあるndk: r29もレシピと一致する。THIRD_PARTY_NOTICES.mdなどの他ドキュメントにレシピのスナップショット値は含まれない。v1.2.28時点と HEAD の両方で確認):CodexReleaseClient.OFFICIAL_REGISTRY = "https://registry.npmjs.org/"で@openai/codexのメタデータを引き、dist.tarballをCodexInstaller.installがdownloadToでダウンロードして SHA-512 integrity を検証する。呼び出し元はCodexRuntime.kt:126とLocalRuntimeInstaller.kt:189。CodexRuntime.startChatgptLogin()がaccount/login/startをtype: chatgptで呼び、CodexTargetがそれを使う。CodexKeepAliveServiceのコメントに auth.openai.com とのトークン交換への言及がある。app/src/fdroid*やapp/src/github*の flavor ソースセットに Codex 関連のコードはない。Codex の導線は main 共通なので、fdroid ビルドにも含まれる。AntiFeature として申告するのは妥当。downloads.claude.ai、Antigravity はaccounts.google.comの OAuth。docs(release): ...はリポジトリの形式に合っている。