ci: stop restoring a cargo registry the Dylint job never reads - #377
Merged
Merged
Conversation
Every compiling Dylint step sets CARGO_HOME to its own temp directory, so the ~/.cargo registry setup-soldr restored (116 MB archive, 29,088 files, 41.2 s) was never used. It was also the slowest of the parallel restores, so it set setup-soldr's wall time (43 s on run 36526568121; the next slowest layers are dylint-cache 16 s and the toolchain 17 s). The linux job already disables it for the same reason. The Dylint job was the only consumer of that registry entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every compiling Dylint step sets CARGO_HOME to its own temp directory, so
the ~/.cargo registry setup-soldr restored (116 MB archive, 29,088 files,
41.2 s) was never used. It was also the slowest of the parallel restores,
so it set setup-soldr's wall time (43 s on run 36526568121; the next
slowest layers are dylint-cache 16 s and the toolchain 17 s). The linux
job already disables it for the same reason. The Dylint job was the only
consumer of that registry entry.