ci: one setup-soldr wrapper with plan-driven cache saves (zackees/ci.yml#92) - #379
Merged
Merged
Conversation
…yml#92) Every job reaches setup-soldr through .github/actions/soldr, which pins the one Soldr runtime (a RUST-013 [[exceptions]] entry, ci.yml#130) and cook-delta off, and takes save-cache from the ci-lint plan's cache_save (true only on a main push). linux and dylints run 'ci_lint plan --github-output' before setup-soldr; build/test/full-coverage/ cache-retention take linux's outputs. setup-uv steps save only on the same flows and carry a pr-<N> suffix in PR context; release and nightly jobs never save. ci/test_cache_policy.py now checks the wrapper calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes zackees/ci.yml#92 (part of zackees/ci.yml#37 / #52, round M2-41).
Changes
.github/actions/soldr/action.ymlis now the onlyzackees/setup-soldr@v0call site (ci-lint CACHE-009/RUST-001). It fixes the inputs every job must share:version: 0.9.23);cook-delta: false.Its required
save-cacheinput is passed straight through.cache-key-pris appended tocache-key-suffixonly when the step saves, so a PR-context save would carrypr-<N>(CACHE-013).Plan-driven saves.
linuxanddylintsnow runci_lint plan --github-outputbefore setup-soldr, and feed itscache_save/cache_key_printo the wrapper:cache_saveistrueonly on a main push, which is exactly the oldgithub.event_name == 'push'policy;linuxexports both values as job outputs forbuild,test,full-coverageandcache-retention;--sha, so aworkflow_dispatchrun plans instead of failing on the missing SHA.Release, crates publish and the nightly macOS guest pass
"false", because they never wrote caches.setup-uv. Every step states
save-cache:falsein the release workflows and the nightly guest;cache-suffixcarriespr-<N>in PR context.ci.toml.
[allow].setup-soldr.require.save-cache = "plan"and[allow].setup-uv.require.save-cache = "plan".[[exceptions]]entry for RUST-013, the runtime pin, whichci/test_cache_policy.pyalready guards asSOLDR_RUNTIME_VERSION. Its bump path is in kernal-api: retire the RUST-013 soldr runtime pin exception ci.yml#130. docs/ci-toml.md names this form of exception as the sanctioned one for RUST-013.Tests.
ci/test_cache_policy.pynow parses the wrapper calls and merges in the wrapper's fixed inputs, and gainstest_only_the_wrapper_calls_setup_soldr.test_auto_release.pyandtest_native_proof_jobs.pyfollow the wrapper too.Evidence:
ci_lint precheck --localat ci.yml@78506e7 (main 92446a5 -> this branch)Local: the CI guard suite (127 tests),
test_auto_release.pyand the other release tests all pass.Not done
ci.toml's cache families and budget are unchanged here. That work is kernal-api: fit the declared cache model inside the 10GB cap ci.yml#93, the next PR.