perf(crash): don't join an in-flight crash sample at exit - #382
Merged
Merged
Conversation
…oining it The sampler's first sample symbolizes against the process binary and can run ~1 s for a debug build; Runtime::drop joined it, so short-lived debug CLIs blocked at exit. Teardown now hands the sink path to the sampler and returns when a capture is in flight; the sampler removes the sink once it has released its handle. Adds a budget test. Fixes #367
zackees
force-pushed
the
fix/crash-sampler-exit-367
branch
from
September 29, 2026 20:30
4fcccae to
f3f89eb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #367.
Teardown no longer blocks on a sampler that is mid-capture (the ~0.9 s first symbolization of a debug binary). It hands the spool-sink path to the sampler and returns; the sampler deletes the sink after dropping its handle (so Windows can delete it). A
doneflag under the same mutex closes the exit race. Budget testteardown_detaches_from_a_sampler_that_is_mid_captureasserts <500 ms teardown against a 1.5 s capture and that the sink is removed.Local: crash tests (19), clippy, fmt, platform Dylint scan pass. Ordinary CI (no ci-full needed; no platform selector added).