Document EnInsect - #1861
Open
Ozero4 wants to merge 2 commits into
Open
Conversation
Contributor
|
Hi! We are trying to keep the contributions covered by the CC0 license, could you review louist103/mm-licensing#1 ? (note: OoT's EnInsect is covered by CC0 based on its git history) |
AngheloAlf
reviewed
Feb 26, 2026
AngheloAlf
approved these changes
Apr 15, 2026
AngheloAlf
added
documentation
hensldm
reviewed
Jul 18, 2026
hensldm
left a comment
hensldm
left a comment
Collaborator
There was a problem hiding this comment.
Sorry its taken so long. Looks good, though I did have some suggestions.
|
|
||
| void func_8091ACC4(EnInsect* this, PlayState* play) { | ||
| void EnInsect_SlowDown(EnInsect* this, PlayState* play) { | ||
| f32 temp_f2; |
Collaborator
There was a problem hiding this comment.
Suggested change
| f32 temp_f2; | |
| f32 playSpeed; |
Seems to make sense.
Comment on lines
186
to
193
| temp_f2 = (Rand_ZeroOne() * 0.8f) + (this->actor.speed * 1.2f); | ||
| if (temp_f2 < 0.0f) { | ||
| this->skelAnime.playSpeed = 0.0f; | ||
| } else { | ||
| f32 clamped = CLAMP_MAX(temp_f2, 1.9f); | ||
|
|
||
| this->skelAnime.playSpeed = clamped; | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| temp_f2 = (Rand_ZeroOne() * 0.8f) + (this->actor.speed * 1.2f); | |
| this->skelAnime.playSpeed = CLAMP(temp_f2, 0.0f, 1.9f); |
This also matches.
| void func_8091AE5C(EnInsect* this, PlayState* play) { | ||
| void EnInsect_Crawl(EnInsect* this, PlayState* play) { | ||
| s32 pad; | ||
| f32 temp_f0; |
Collaborator
There was a problem hiding this comment.
Suggested change
| f32 temp_f0; | |
| f32 playSpeed; |
Again seems like a good name.
| void func_8091B07C(EnInsect* this, PlayState* play) { | ||
| void EnInsect_RunFromPlayer(EnInsect* this, PlayState* play) { | ||
| s32 pad; | ||
| f32 speed; |
Collaborator
There was a problem hiding this comment.
Suggested change
| f32 speed; | |
| f32 playSpeed; |
To match the other instances I've suggested.
|
|
||
| Math_SmoothStepToF(&this->actor.speed, 0.0f, 0.1f, 0.5f, 0.0f); | ||
| Math_StepToS(&this->actor.shape.rot.x, 0x2AAA, 0x160); | ||
| Math_StepToS(&this->actor.shape.rot.x, 10922, 352); |
Collaborator
There was a problem hiding this comment.
Suggested change
| Math_StepToS(&this->actor.shape.rot.x, 10922, 352); | |
| Math_StepToS(&this->actor.shape.rot.x, 0x2AAA, 0x160); |
Rotation so should stay in hex.
| }; | ||
|
|
||
| Vec3f D_8091BDCC = { 0.0f, 0.0f, 0.0f }; | ||
| static Vec3f accel = { 0.0f, 0.0f, 0.0f }; |
Collaborator
There was a problem hiding this comment.
Suggested change
| static Vec3f accel = { 0.0f, 0.0f, 0.0f }; | |
| static Vec3f sAccel = { 0.0f, 0.0f, 0.0f }; |
Static variable so should be prefixed with an s
| void EnInsect_WalkOnWater(EnInsect* this, PlayState* play) { | ||
| s32 pad[2]; | ||
| s16 temp; | ||
| Vec3f sp40; |
Collaborator
There was a problem hiding this comment.
Suggested change
| Vec3f sp40; | |
| Vec3f ripplePos; |
hensldm
added
the
Waiting-for-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation based on Oot