Document an includes style, apply to z_demo.c and z_play.c - #2803
Open
Dragorn421 wants to merge 5 commits into
Open
Document an includes style, apply to z_demo.c and z_play.c#2803Dragorn421 wants to merge 5 commits into
Dragorn421 wants to merge 5 commits into
Conversation
Contributor
|
my only disagreement is that I greatly dislike having special rules only for overlays |
Collaborator
Author
|
We could also have .h includes corresponding to the .c for boot/code files at the top of the .c, (eg play_state.h for z_play.c) but that's much less easy to identify and will not be consistent either (like, not all .c in boot/code have a .h) ? |
Thar0
requested changes
Aug 18, 2026
mzxrules
reviewed
Aug 20, 2026
AngheloAlf
approved these changes
Aug 22, 2026
AngheloAlf
left a comment
AngheloAlf
left a comment
Contributor
There was a problem hiding this comment.
The proposed include order is kinda the opposite of what we have been doing, but I guess it is fine
mzxrules
approved these changes
Aug 28, 2026
mzxrules
left a comment
mzxrules
left a comment
Contributor
There was a problem hiding this comment.
Would like this as is for MM too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest an includes style: see docs/includes.md
Basically,
<>for libc includesThis aims to be the basis for future includes cleanup