Useful Eventchkinf flag renames - #2807
Open
Olvivi wants to merge 6 commits into
Open
Conversation
Dragorn421
reviewed
Aug 27, 2026
Dragorn421
left a comment
Dragorn421
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the PR!
some small comments
| #define EVENTCHKINF_42 0x42 | ||
| #define EVENTCHKINF_43 0x43 | ||
| #define EVENTCHKINF_45 0x45 | ||
| #define EVENTCHKINF_MASTER_SWORD_PULLED 0x45 |
Collaborator
There was a problem hiding this comment.
I feel like naming this "PULLED" could be interpreted as a "is master sword not in pedestal" flag, which would only be true as adult, instead of what this flag is which is "has master sword been gotten once yet"
maybe:
Suggested change
| #define EVENTCHKINF_MASTER_SWORD_PULLED 0x45 | |
| #define EVENTCHKINF_OBTAINED_MASTER_SWORD 0x45 |
it doesn't look like there's another flag for "has obtained master sword" based on the surrounding of Item_Give(play, ITEM_SWORD_MASTER); in z_bg_toki_swd.c so this should be fine?
Co-authored-by: Dragorn421 <Dragorn421@users.noreply.github.com>
Dragorn421
approved these changes
Aug 28, 2026
Dragorn421
added
the
One approval
mzxrules
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found some eventchkinf flags that have a wide enough range it's valuable to know what they mean on sight.
Gerudo caught/Tower collapse flag retains both names because it's actively used for both cases; Zelda (z_En_zl3) will clear the flag for use in z_demo.
40 = OBTAINED_ZELDA_LETTER (+index)
45 = MASTER_SWORD_PULLED
80 = ZELDA_FLED_CASTLE
C7 = GERUDO_CAUGHT_TOWER_FALL
(Added comment to C7 in save.h)