Skip to content

Decompile ActorNaviBase - #149

Draft
mike8699 wants to merge 44 commits into
zeldaret:mainfrom
mike8699:actor-navi-base
Draft

Decompile ActorNaviBase#149
mike8699 wants to merge 44 commits into
zeldaret:mainfrom
mike8699:actor-navi-base

Conversation

@mike8699

@mike8699 mike8699 commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Closes #82

@decomp-dev

decomp-dev Bot commented Apr 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Report for eur (29e3578 - a9551fc)

📈 Matched code: 3.09% (+0.25%, +8956 bytes)
📈 Matched data: 2.37% (+0.00%, +4 bytes)

✅ 50 new matches
Unit Item Bytes Before After
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_e0() +1067 0.15% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_bc(int, char, Vec3p*) +1024 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_14(unsigned int) +871 0.18% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_18(unsigned int) +783 0.20% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_cc(int*) +715 0.22% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_78(int) +648 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_90(int, int) +547 0.29% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_e8() +387 0.41% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::SetActive(int) +347 0.46% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_94(int, int) +323 0.49% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b9fe8() +235 0.68% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b8c98(int, int, int) +155 1.03% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_20(bool) +155 1.03% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_10(unsigned int) +147 1.08% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_d0() +139 1.14% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba458() +139 1.14% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba53c() +115 1.38% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b9770(int) +111 1.43% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020baca8(Vec3p*, int) +111 1.43% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba3b4() +95 1.67% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::TeleportAboveLink() +87 1.82% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba4e4() +87 1.82% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_c0(Vec3p*) +79 2.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b8c50(int) +71 2.22% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba414(Vec3p*) +67 2.35% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase func_ov000_020b8790(int) +60 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase func_ov000_020b87cc(int) +60 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_74(ActorRef*) +51 3.08% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020bb0ac() +51 3.08% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020bb0e0() +51 3.08% 100.00%

...and 20 more new matches

🥀 3 broken matches
Unit Item Bytes Before After
src/00_Core/Actor/Actor Actor::vfunc_78() -8 100.00% 0.00%
src/14_Land/Actor/Character/ActorCharacter ActorCharacter::vfunc_78() -8 100.00% 0.00%
src/04_Load/Actor/Navi/ActorNavi_04 ActorNaviBase::ActorNaviBase() -1 100.00% 99.99%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_d4() +1042 0.15% 95.56%
src/00_Core/Actor/Navi/ActorNaviBase .rodata +85 0.00% 97.40%
src/00_Core/Actor/Navi/ActorNaviBase .data +32 0.00% 9.01%
📉 3 regressions in unmatched items
Unit Item Bytes Before After
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b9fdc() -1 13.33% 0.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_78() -1 0.25% 0.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_bc(int, char, int) -1 0.16% 0.00%

Report for usa (29e3578 - a9551fc)

📈 Matched code: 3.06% (+0.25%, +8956 bytes)
📈 Matched data: 2.34% (+0.00%, +4 bytes)

✅ 50 new matches
Unit Item Bytes Before After
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_e0() +1067 0.15% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_bc(int, char, Vec3p*) +1024 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_14(unsigned int) +871 0.18% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_18(unsigned int) +783 0.20% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_cc(int*) +715 0.22% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_78(int) +648 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_90(int, int) +547 0.29% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_e8() +387 0.41% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::SetActive(int) +347 0.46% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_94(int, int) +323 0.49% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b9fe8() +235 0.68% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b8c98(int, int, int) +155 1.03% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_20(bool) +155 1.03% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_10(unsigned int) +147 1.08% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_d0() +139 1.14% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba458() +139 1.14% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba53c() +115 1.38% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b9770(int) +111 1.43% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020baca8(Vec3p*, int) +111 1.43% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba3b4() +95 1.67% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::TeleportAboveLink() +87 1.82% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba4e4() +87 1.82% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_c0(Vec3p*) +79 2.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b8c50(int) +71 2.22% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020ba414(Vec3p*) +67 2.35% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase func_ov000_020b8790(int) +60 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase func_ov000_020b87cc(int) +60 0.00% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_74(ActorRef*) +51 3.08% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020bb0ac() +51 3.08% 100.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020bb0e0() +51 3.08% 100.00%

...and 20 more new matches

🥀 3 broken matches
Unit Item Bytes Before After
src/00_Core/Actor/Actor Actor::vfunc_78() -8 100.00% 0.00%
src/14_Land/Actor/Character/ActorCharacter ActorCharacter::vfunc_78() -8 100.00% 0.00%
src/04_Load/Actor/Navi/ActorNavi_04 ActorNaviBase::ActorNaviBase() -1 100.00% 99.99%
📈 3 improvements in unmatched items
Unit Item Bytes Before After
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_d4() +1042 0.15% 95.56%
src/00_Core/Actor/Navi/ActorNaviBase .rodata +85 0.00% 97.40%
src/00_Core/Actor/Navi/ActorNaviBase .data +32 0.00% 9.01%
📉 3 regressions in unmatched items
Unit Item Bytes Before After
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::func_ov000_020b9fdc() -1 13.33% 0.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_78() -1 0.25% 0.00%
src/00_Core/Actor/Navi/ActorNaviBase ActorNaviBase::vfunc_bc(int, char, int) -1 0.16% 0.00%

@mike8699
mike8699 force-pushed the actor-navi-base branch 2 times, most recently from c7a8bb6 to e33cee9 Compare April 23, 2026 23:09
mike8699 added 24 commits August 22, 2026 13:30
@mike8699
ActorNaviBase: scaffolding and simple trivially-matching functions
3a3977d
@mike8699
ActorNaviBase: decompile vfunc_80
efa8db5
@mike8699
ActorNaviBase: decompile vfunc_d0
dbfd420
@mike8699
ActorNaviBase: decompile func_ov000_020b8c50
ecbd536
@mike8699
ActorNaviBase: decompile func_ov000_020b8c98
5bfa642
@mike8699
ActorNaviBase: decompile SetActive
692577a
@mike8699
ActorNaviBase: decompile TeleportAboveLink
6b87258
@mike8699
ActorNaviBase: decompile func_ov000_020b9770
c07f5c6
@mike8699
ActorNaviBase: decompile vfunc_e8
9e36da8
@mike8699
ActorNaviBase: decompile func_ov000_020b9fdc
02cbfed
@mike8699
ActorNaviBase: decompile func_ov000_020b9fe8
219e077
@mike8699
ActorNaviBase: decompile vfunc_10
f1ae0ab
@mike8699
ActorNaviBase: decompile vfunc_c0
c30805f
@mike8699
ActorNaviBase: decompile func_ov000_020ba3b4
b82d49c
@mike8699
ActorNaviBase: decompile func_ov000_020ba414
b4d83c9
@mike8699
ActorNaviBase: decompile func_ov000_020ba458
6a1250f
@mike8699
ActorNaviBase: decompile func_ov000_020ba4e4
d4e4271
@mike8699
ActorNaviBase: decompile func_ov000_020ba53c
58a76b5
@mike8699
ActorNaviBase: decompile func_ov000_020baca8
107500b
@mike8699
ActorNaviBase: decompile func_ov000_020bb0ac
fe25724
@mike8699
ActorNaviBase: decompile func_ov000_020bb0e0
ea0525e
@mike8699
ActorNaviBase: decompile func_ov000_020ba350
273a2a3
@mike8699
ActorNaviBase: decompile vfunc_74
2886af4
@mike8699
ActorNaviBase: decompile vfunc_20
e9db748
@mike8699
mike8699 force-pushed the actor-navi-base branch 3 times, most recently from 0474858 to 01ced39 Compare August 22, 2026 19:55
@mike8699
mike8699 force-pushed the actor-navi-base branch 3 times, most recently from f65ad9f to 8c53e88 Compare August 23, 2026 16:04
mike8699 added 19 commits August 23, 2026 13:38
@mike8699
ActorNaviBase: decompile vfunc_cc
3681510
@mike8699
ActorNaviBase: decompile vfunc_e0
7df441e
@mike8699
ActorNaviBase: decompile vfunc_18
8659992
@mike8699
ActorNaviBase: decompile vfunc_14
e57cd9f
@mike8699
ActorNaviBase: decompile vfunc_bc
9306607
@mike8699
ActorNaviBase: decompile vfunc_94
8dc6110
@mike8699
ActorNaviBase: use UnkStruct_ov000_020e8b08::Contains in vfunc_cc
426c0a9
@mike8699
ActorNaviBase: decompile vfunc_90
504c9ec
@mike8699
ActorNaviBase: decompile vfunc_78
333d9bc
@mike8699
ActorNaviBase: vfunc_d4 in progress (93%)
56a2f56
@mike8699
ActorNaviBase: give func_ov000_02087e8c its C++ mangled name
ad65e22
@mike8699
ActorNaviBase: define the TU's own data instead of extern-ing it
884b0e5
@mike8699
ActorNaviBase: attribute three helpers to their classes
2b3f3d8
@mike8699
ActorNaviBase: move shared declarations into headers
eb71bd8
@mike8699
ActorNaviBase: simplify copies, loops and casts
414d629
@mike8699
ActorNaviBase: for loops for the visibility flag updates
121e69b
@mike8699
ActorNaviBase: drop unnecessary casts
e986126
@mike8699
ActorNaviBase: remove the remaining extern declarations
57f0922
@mike8699
ActorNaviBase: for loop in SetActive
b0aa072
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

src/00_Core/Actor/Navi/ActorNaviBase.cpp

1 participant

@mike8699