Decompiling MapObjectUnkLTRW - #142
Merged
Merged
Conversation
Report for eur1 (db8e927 - 1053725)No changesReport for jp (db8e927 - 1053725)📈 Matched code: 8.51% (+0.02%, +1064 bytes) ✅ 16 new matches
📉 7 regressions in unmatched items
Report for eur (db8e927 - 1053725)📈 Matched code: 8.56% (+0.02%, +1064 bytes) ✅ 16 new matches
📉 7 regressions in unmatched items
Report for usa (db8e927 - 1053725)No changes |
Contributor
Author
|
For some damn reason, I cannot complete this because of some vtable order... |
Mityno
marked this pull request as ready for review
August 22, 2026 21:48
Yanis002
reviewed
Aug 23, 2026
Collaborator
are you sure the base vtable has the exact same number of vfuncs? I think it might work if you remove at least one |
Contributor
Author
Well I overrode none, so I don't see a way to put any less. The Base does inherit 4 vfuncs from Also I checked, the symbol delink looks right to me (the Base vtable is above the Profile's one, so anyway my compiled ordering is wrong). |
Co-authored-by: Yanis <35189056+Yanis002@users.noreply.github.com>
Collaborator
|
this has merge conflicts now |
Mityno
marked this pull request as draft
August 24, 2026 13:17
Mityno
marked this pull request as ready for review
August 24, 2026 13:32
Collaborator
|
I'm sorry about the conflicts, it shouldn't be too long though I think |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also cleanup on some ov063 actors :<)