Repository navigation
CI fix: regenerate diagnostics - #957
Merged
Merged
Conversation
TheJulianJES
approved these changes
Oct 20, 2026
puddly
marked this pull request as ready for review
October 20, 2026 15:58
puddly
enabled auto-merge (squash)
October 20, 2026 15:58
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Both fixture changes match the device-bound sensor behavior and are covered by existing diagnostics comparison tests.
No open issues 🎉
What changed in this PR
Updates the Sonoff S60 diagnostics fixture to match the device-bound sensors introduced in #919.
Changes:
- Sets LQI and RSSI sensor
endpoint_idvalues tonull.
| File | Description |
|---|---|
| tests/data/devices/sonoff-s60zbtpf-0x00002103.json | Aligns sensor endpoint metadata with device-bound behavior. |
Review effort: Balanced
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #957 +/- ##
==========================================
- Coverage 97.23% 97.22% -0.01%
==========================================
Files 61 61
Lines 10668 10676 +8
==========================================
+ Hits 10373 10380 +7
- Misses 295 296 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#919 wasn't up-to-date with
devand a few diagnostics need to be updated.