Repository navigation
Conversation
Hello on embedded stack stackHello on embedded stack start
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 1213 1217 +4
=========================================
+ Hits 1213 1217 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
A WebSocket Hello received while the initial Reset request is pending can be mistaken for startup traffic, silently ignoring a real reset and leaving the request unresolved.
1 open issue
What changed in this PR
This PR distinguishes embedded Ziggurat’s initial startup Hello from later firmware-reset notifications, preventing a false disconnect during stack startup.
Changes:
- Track whether the API has received a frame and ignore a session-opening
Hello. - Add startup coverage and update the reset-notification test to establish prior traffic.
| File | Description |
|---|---|
zigpy_ziggurat/zigbee/api.py |
Track received frames to distinguish startup announcements from resets. |
tests/test_api.py |
Test startup Hello handling and subsequent reset detection. |
Review effort: Balanced
Comment on lines
+270
to
+271
| if not self._received_frame: | ||
| return |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The first
Hello()is sent unsolicited by embedded Ziggurat and isn't an immediate firmware reset.We should maybe include a reset reason in the
Hello()message.