Skip to content

Fix MgmtRtgRsp.Routes not being marked as optional #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
funkzy wants to merge 2 commits into from
Closed

Fix MgmtRtgRsp.Routes not being marked as optional #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ae3f9d
Fix: mark MgmtRtgRsp.Routes optional to prevent frame-processing cras…
Aug 10, 2026
4907f4f
Add regression test for `MgmtRtgRsp` with `Status=NOT_SUPPORTED`
funkzy Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions tests/test_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,3 +559,19 @@ def test_neighbors_missing_payload():
Src=0x821F,
Status=t.ZDOStatus.NOT_SUPPORTED,
)


def test_routes_missing_payload():
frame = frames.GeneralFrame(
header=t.CommandHeader(
id=0xB2,
subsystem=t.Subsystem.ZDO,
type=t.CommandType.AREQ,
),
data=b"\x85\xCC\x84",
)

assert c.ZDO.MgmtRtgRsp.Callback.from_frame(frame) == c.ZDO.MgmtRtgRsp.Callback(
Src=0xCC85,
Status=t.ZDOStatus.NOT_SUPPORTED,
)
2 changes: 1 addition & 1 deletion zigpy_znp/commands/zdo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1194,7 +1194,7 @@ class ZDO(t.CommandsBase, subsystem=t.Subsystem.ZDO):
t.Param(
"Status", t.ZDOStatus, "Status is either Success (0) or Failure (1)"
),
t.Param("Routes", zigpy.zdo.types.Routes, "Routes"),
t.Param("Routes", zigpy.zdo.types.Routes, "Routes", optional=True),
),
)

Expand Down
Loading