Skip to content

fix(runtime): move to patched Node 26 LTS - #1301

Merged
nicobao merged 2 commits into
zkorum:mainfrom
nicobao:fix/node-november-2026-security
Nov 13, 2026
Merged

nicobao merged 2 commits into
zkorum:mainfrom
nicobao:fix/node-november-2026-security

Conversation

@nicobao

@nicobao nicobao commented Nov 13, 2026

Copy link
Copy Markdown
Member

Summary

  • Standardize local development, CI, Netlify, Docker build/runtime stages, and application engine requirements on Node.js 26.13.1 LTS, including the November security fixes.
  • Bootstrap the existing pnpm 12.4.1 pin through npm: Node 26 no longer includes Corepack. Preserve CA requirements and existing dependency/supply-chain policies.
  • Upgrade the Quasar frontend to Vitest 5.1.0, using its upstream Node 26/jsdom storage fix. No Web Storage disabling flag, global monkey-patch, or application polyfill remains.
  • Add CI runtime/bootstrap consistency checks and update deployment docs and the nginx test fixture.

Validation

Run using Node 26.13.1 and pnpm 12.4.1:

  • Clean frozen-lockfile installs for all four application services
  • API and conversation-email-update-worker builds and typechecks
  • Quasar production compilation, rerun after the Vitest upgrade
  • SvelteKit production build including Netlify adapter output; typecheck: zero errors/warnings
  • API and email-worker Docker production image builds on linux/arm64, followed by offline runtime/native-module/email-renderer import checks
  • Quasar: 1,755 tests pass, using Vitest 5 with no Web Storage workaround
  • Email worker: 275 tests pass
  • Landing page: 109 tests pass
  • Runtime/package-manager/email-build/deployment checks: 28 pass
  • nginx integration/deployment checks: 14 pass
  • Changed JS test files and frontend manifest formatting; staged diff whitespace check

Known pre-existing API test failure

API service tests: 732 pass, 1 fails. src/service/maxdiffHistory.test.ts:488 expects a score of 0.6 but receives 1. The same isolated assertion also fails on Node 24.22.3, confirming it is not introduced by this runtime migration. No unrelated scoring code was changed.

Frontend compilation used non-secret placeholder settings and did not upload Sentry artifacts. Full frontend Docker images and production deployment were not performed; backend Docker images were built locally only.

Deployment

Rebuild and publish fresh API, email-worker, and Agora image tags; set the existing Compose tag variables and recreate the affected containers. Redeploy the Netlify landing page. Existing images/processes do not automatically adopt the new runtime. Unrelated nginx/database/infrastructure version upgrades are intentionally excluded.

Deploy: app, agora, api, conversation-email-update-worker

Adopt Node.js 26.13.1 LTS with the November 2026 security fixes across local development, CI, Netlify, and all Node-based Docker build and runtime stages. Require the patched Node 26 release line in the four application service manifests rather than continuing to advertise older runtime majors.

Install the existing pinned pnpm 12.4.1 through npm in Docker builds because Node 26 no longer bundles Corepack. Preserve the existing CA minimums, platform handling, dependency build permissions, and supply-chain policies. Update deployment guidance and the nginx integration test's Node fixture.

Upgrade the Quasar frontend to Vitest 5.1.0 and regenerate only its lockfile to use the upstream Node 26 jsdom storage fix without disabling Web Storage or installing application shims. Add CI regression checks for runtime pins and the npm-based pnpm bootstrap.

Validation on Node 26.13.1:
- Clean frozen installs and builds for API, Agora, landing page, and email worker.
- API and email-worker ARM64 Docker image builds and runtime import checks.
- API and worker typechecks; landing typecheck with zero diagnostics.
- 1,755 Agora, 275 email-worker, and 109 landing unit tests pass.
- Runtime, package-manager, email-build, deployment, and nginx checks pass.
- API service tests: 732 pass and one existing MaxDiff score-scale assertion fails. The same assertion fails on Node 24.22.3; leave the unrelated scoring behavior unchanged.

Frontend compilation uses non-secret placeholder environment settings and does not upload Sentry artifacts. Production images still require rebuilding, publishing fresh tags, and redeployment.

References:
https://nodejs.org/en/blog/vulnerability/november-2026-security-releases
vitest-dev/vitest#10867

Deploy: app, agora, api, conversation-email-update-worker
@netlify

netlify Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

👷 Deploy request for agoracitizen pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3f3a71b

Keep the README focused on general development setup instead of documenting a particular security advisory, deployment reminder, and runtime-pin test invocation. Security maintenance details remain in the change history and pull request.

Deploy: none
@nicobao
nicobao merged commit 2f6305d into zkorum:main Nov 13, 2026
2 checks passed
@nicobao
nicobao deleted the fix/node-november-2026-security branch November 13, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant