Repository navigation
fix(runtime): move to patched Node 26 LTS - #1301
Merged
Merged
Conversation
Adopt Node.js 26.13.1 LTS with the November 2026 security fixes across local development, CI, Netlify, and all Node-based Docker build and runtime stages. Require the patched Node 26 release line in the four application service manifests rather than continuing to advertise older runtime majors. Install the existing pinned pnpm 12.4.1 through npm in Docker builds because Node 26 no longer bundles Corepack. Preserve the existing CA minimums, platform handling, dependency build permissions, and supply-chain policies. Update deployment guidance and the nginx integration test's Node fixture. Upgrade the Quasar frontend to Vitest 5.1.0 and regenerate only its lockfile to use the upstream Node 26 jsdom storage fix without disabling Web Storage or installing application shims. Add CI regression checks for runtime pins and the npm-based pnpm bootstrap. Validation on Node 26.13.1: - Clean frozen installs and builds for API, Agora, landing page, and email worker. - API and email-worker ARM64 Docker image builds and runtime import checks. - API and worker typechecks; landing typecheck with zero diagnostics. - 1,755 Agora, 275 email-worker, and 109 landing unit tests pass. - Runtime, package-manager, email-build, deployment, and nginx checks pass. - API service tests: 732 pass and one existing MaxDiff score-scale assertion fails. The same assertion fails on Node 24.22.3; leave the unrelated scoring behavior unchanged. Frontend compilation uses non-secret placeholder environment settings and does not upload Sentry artifacts. Production images still require rebuilding, publishing fresh tags, and redeployment. References: https://nodejs.org/en/blog/vulnerability/november-2026-security-releases vitest-dev/vitest#10867 Deploy: app, agora, api, conversation-email-update-worker
👷 Deploy request for agoracitizen pending review.Visit the deploys page to approve it
|
Keep the README focused on general development setup instead of documenting a particular security advisory, deployment reminder, and runtime-pin test invocation. Security maintenance details remain in the change history and pull request. Deploy: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Run using Node 26.13.1 and pnpm 12.4.1:
Known pre-existing API test failure
API service tests: 732 pass, 1 fails.
src/service/maxdiffHistory.test.ts:488expects a score of0.6but receives1. The same isolated assertion also fails on Node 24.22.3, confirming it is not introduced by this runtime migration. No unrelated scoring code was changed.Frontend compilation used non-secret placeholder settings and did not upload Sentry artifacts. Full frontend Docker images and production deployment were not performed; backend Docker images were built locally only.
Deployment
Rebuild and publish fresh API, email-worker, and Agora image tags; set the existing Compose tag variables and recreate the affected containers. Redeploy the Netlify landing page. Existing images/processes do not automatically adopt the new runtime. Unrelated nginx/database/infrastructure version upgrades are intentionally excluded.
Deploy: app, agora, api, conversation-email-update-worker