feat: add hardware frame context wrappers - #274
Open
jb-alvarado wants to merge 9 commits into
Open
Conversation
Expose safe wrappers for FFmpeg hardware device and frame contexts, including frame allocation and software-to-hardware uploads. Allow video encoders to receive a cloned hardware frame context before opening.
AdrianEddy
reviewed
Jul 20, 2026
| #[inline] | ||
| pub fn upload(&self, source: &frame::Video) -> Result<frame::Video, Error> { | ||
| let mut destination = self.allocate_video()?; | ||
| destination.set_pts(source.pts()); |
Collaborator
There was a problem hiding this comment.
this needs the full av_frame_copy_props, not only pts
Collaborator
|
Contributor
Author
|
Thanks @AdrianEddy, for reviewing my pull request. I implemented your suggestions and added also an example. |
…st-ffmpeg into feature/hardware-contexts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose safe wrappers for FFmpeg hardware device and frame contexts, including frame allocation and software-to-hardware uploads. Allow video encoders to receive a cloned hardware frame context before opening.