Skip to content

558 display tld url - #559

Open
tbleckert wants to merge 4 commits into
zonemaster:developfrom
tbleckert:558-display-tld-url
Open

tbleckert wants to merge 4 commits into
zonemaster:developfrom
tbleckert:558-display-tld-url

Conversation

@tbleckert

Copy link
Copy Markdown
Collaborator

Purpose

This PR displays the TLD URL on the result page using the existing hidden UI.

Context

Fixes #558.

Changes

  • Fetch the URL using get_tld_url for the tested domain.
  • Show the existing URL and copy control when a URL is available.
  • Keep the control hidden when no URL is returned or the request fails.
  • Add e2e coverage for displaying, copying, and handling unavailable URLs.

How to test this PR

npm run e2e -- e2e/TldUrl.e2e-spec.ts

Or manually run a domain test and verify that the TLD URL button displays the returned URL and copies it correctly. Verify that the button stays hidden when no URL is available.

@tbleckert
tbleckert changed the base branch from master to develop September 30, 2026 12:33
@matsduf matsduf added T-Feature Type: New feature in software or test case description V-Minor Versioning: The change gives an update of minor in version. RC-Features Release category: Features. labels Sep 30, 2026
@matsduf matsduf added this to the v2026.2 milestone Sep 30, 2026
@matsduf matsduf linked an issue Sep 30, 2026 that may be closed by this pull request
@matsduf

matsduf commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

I have compiled and tested the updated GUI. Everything works as it should. URL is available when it should, and absent when it should be absent. However, I think it is presented in a way where few will even see it, and to use the URL is too clumsy.

This is how it looks like:

image

I would like to see some other text than "TLD URL". Maybe "Get more info for the domain name", but that is too long.

Clicking on it makes the link show up:

image

To use the link you have to click the copy button and then past the URL into the web browser. Instead of showing the URL there could be two buttons, "open" and "copy URL", respectively.

@matsduf

matsduf commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

My suggestion is that text on the button is " web" where <TLD> is the TLD of the domain name, e.g. "dk web" or ".dk web". The API responds with the TLD in the tld key. E.g.:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "tld": "fr",
    "url": "http://www.afnic.fr",
    "source": "BACKEND CONF"
  }
}

@matsduf

matsduf commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

The proposal to display a URL to the TLD comes from @haarbo. His proposal was:

image

@rhedman

rhedman commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

I have compiled and tested the updated GUI. Everything works as it should. URL is available when it should, and absent when it should be absent. However, I think it is presented in a way where few will even see it, and to use the URL is too clumsy.

This is how it looks like:

image I would like to see some other text than "TLD URL". Maybe "Get more info for the domain name", but that is too long.

Clicking on it makes the link show up:

image To use the link you have to click the copy button and then past the URL into the web browser. Instead of showing the URL there could be two buttons, "open" and "copy URL", respectively.

The link must be shown, otherwise the user won't know what they copy or follow. But we can probably add a "Follow link" button along with the Copy button.

@rhedman

rhedman commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

My suggestion is that text on the button is " web" where <TLD> is the TLD of the domain name, e.g. "dk web" or ".dk web". The API responds with the TLD in the tld key. E.g.:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": {
    "tld": "fr",
    "url": "http://www.afnic.fr",
    "source": "BACKEND CONF"
  }
}

The button text can be anything as long as it's short. So we'll just change it into whatever you decide.

@matsduf

matsduf commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

The button text can be anything as long as it's short. So we'll just change it into whatever you decide.

If the button text includes the TLD name plus a short string, e.g. "web" or "FAQ", then it will usually not be long since the names of the most used TLDs are short, but there are exceptions. I guess then the text in button will be truncated or the button will become wide and cause line break.

In the suggestion from @haarbo the TLD URL button is above the share button. Could that work? Could it then expand to the left if needed? What do you think, @tbleckert and @rhedman?

@matsduf

matsduf commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

The link must be shown, otherwise the user won't know what they copy or follow. But we can probably add a "Follow link" button along with the Copy button.

I think that is a good suggestion.

@matsduf

matsduf commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

The small "window" that shows the link seems to have fixed or maximal length. The following URL that I got is too long and the entire URL is not shown. Should'nt the "window" be dynamic to be able to show even long URLs?

https://internetstiftelsen.se/en/domains/?domain=finnsinte.se

@rhedman

rhedman commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

The small "window" that shows the link seems to have fixed or maximal length. The following URL that I got is too long and the entire URL is not shown. Should'nt the "window" be dynamic to be able to show even long URLs?

https://internetstiftelsen.se/en/domains/?domain=finnsinte.se

It's as long as it can be within it's parent container. Same for the Share URL. It doesn't have to all be visible and it wouldn't work on smaller screens anyway.

But I suppose we could do something like this:

Screen.Recording.2026-10-14.at.15.19.25.mov

@matsduf

matsduf commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

@rhedman, the URL is scrolling and there is an open URL button - fine. But the text on the main TLD URL button is still TLD URL instead of .dk Info as expected in the example.


image

@rhedman

rhedman commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator

@rhedman, the URL is scrolling and there is an open URL button - fine. But the text on the main TLD URL button is still TLD URL instead of .dk Info as expected in the example.

image

This is not ready for test, this is for Tobias to continue working on the feature.

@rhedman

rhedman commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

@matsduf This is completed from our side but you and the team have to decide on the micro copy for the text above the URL input field "Placeholder information about the TLD URL".

@matsduf

matsduf commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

My suggestion for the "Placeholder information about the TLD URL":

"The link goes to the top-level domain of the tested domain. In most cases you can find information about the tested domain and the registrar under which it is tested. If you run a TLD you can arrange for a more specific URL. See the Zonemaster documentation."

@marc-vanderwal, @tgreenx, @MichaelTimbert, @mattias-p, @tolvmannen, @MarkusVidefors, @benoitam, @rhedman, @tbleckert : Please comment!

@rhedman

rhedman commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

My suggestion for the "Placeholder information about the TLD URL":

"The link goes to the top-level domain of the tested domain. In most cases you can find information about the tested domain and the registrar under which it is tested. If you run a TLD you can arrange for a more specific URL. See the Zonemaster documentation."

@marc-vanderwal, @tgreenx, @MichaelTimbert, @mattias-p, @tolvmannen, @MarkusVidefors, @benoitam, @rhedman, @tbleckert : Please comment!

In my opinion this suggestion is way too long. The text might be suitable for an FAQ question but for this purpose the text needs to be shorter.

Screenshot 2026-10-26 at 14 21 10

@matsduf

matsduf commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

In my opinion this suggestion is way too long. The text might be suitable for an FAQ question but for this purpose the text needs to be shorter.

Do you still think it is too long if it is cut down to (with some corrections) the following?

"The link goes to the top-level domain of the tested domain name. In most cases you can find information about the tested domain name and the registrar under which it is registered."

An FAQ on TLD URL could probably be a good idea, now or the first release next year.

@rhedman

rhedman commented Oct 26, 2026

Copy link
Copy Markdown
Collaborator

In my opinion this suggestion is way too long. The text might be suitable for an FAQ question but for this purpose the text needs to be shorter.

Do you still think it is too long if it is cut down to (with some corrections) the following?

"The link goes to the top-level domain of the tested domain name. In most cases you can find information about the tested domain name and the registrar under which it is registered."

An FAQ on TLD URL could probably be a good idea, now or the first release next year.

Yes, still too long. How about "The link goes to the top-level domain of the tested domain name."

@matsduf

matsduf commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

I suspect that many people do not know what a TLD is and why it is relevant. I hope to get comments from more people.

@matsduf

matsduf commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@oermen, please check the suggestion of replacement text instead of "placeholder".

@rhedman

rhedman commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

I suspect that many people do not know what a TLD is and why it is relevant. I hope to get comments from more people.

Hence the need for an FAQ about this. :)

@matsduf

matsduf commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Hence the need for an FAQ about this. :)

Yes, but we cannot link to an FAQ entry, can we?

@rhedman

rhedman commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

Hence the need for an FAQ about this. :)

Yes, but we cannot link to an FAQ entry, can we?

Yes we can :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RC-Features Release category: Features. T-Feature Type: New feature in software or test case description V-Minor Versioning: The change gives an update of minor in version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display TLD URL on result page TLD specific links in result page on Zonemaster GUI

3 participants