Conversation
mzdnick
force-pushed
the
mazda-lkas-setting-alert
branch
2 times, most recently
from
September 13, 2026 23:36
3bdde9e to
e2b3255
Compare
mzdnick
marked this pull request as ready for review
September 14, 2026 05:48
mzdnick
force-pushed
the
mazda-lkas-setting-alert
branch
3 times, most recently
from
September 14, 2026 10:20
dc8c945 to
f7986ef
Compare
mzdnick
force-pushed
the
mazda-lkas-setting-alert
branch
5 times, most recently
from
September 15, 2026 15:53
8afc4b6 to
e5eba71
Compare
Issue: a settings-menu or camera state can leave the EPS taking our steer request and applying none of it, with no block or fault. Fix: detect the silent zero-delivery in CarState and raise invalidLkasSetting; gate the detection on the steer-to-zero EPS; drop the LANE_LINES term it superseded. Superseded by the next commit, which reads the camera's own intervention bits instead. Validation: 552 tests on this tree; delivery measured on routes (LKAS_EFFECTIVE tracks the request when healthy).
CAM_SETTINGS.LKAS_INERVENTION_ON1 and ILKAS_NTERVENTION_ON2 clear together when the lane assist is off
mzdnick
force-pushed
the
mazda-lkas-setting-alert
branch
from
September 15, 2026 16:01
e5eba71 to
71d2f21
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LANE_LINES == 0(CarState: add invalidLkasSetting commaai/opendbc#1325, left with a "TODO: is this needed?") is not needed. It reads zero in sustained stretches at road speed while steering is delivered. An unmarked road is not an invalid setting.Fix
CAM_SETTINGS(0x485) carries the setting: both intervention bits are set while lane keep is on and clear when it is off. Either bit clear raisesinvalidLkasSetting, keeping the existing alert and no-entry gate.canValid.Validation
AI Usage
Disclaimer: GLM-5.3 by Z.ai was used to help develop, debug, and document this
submission. All changes were reviewed and validated by a human.