Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused configuration and documentation changes match #296; live connectivity checks remain post-sync verification.
No open issues 🎉
What changed in this PR
Closes #296 by blocking external connections to flick_prod while preserving Render private-network access.
Changes:
- Sets an explicit empty database IP allow list.
- Documents approved access methods and the security rationale.
| File | Description |
|---|---|
render.yaml |
Blocks external database connections. |
docs/decisions/7-closed-database-allow-list.md |
Records the rationale and tooling tradeoffs. |
AGENTS.md |
Documents production data access and temporary IP cleanup. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #296.
This closes
flick_prodto external connections by settingipAllowList: []inrender.yaml. Until now the password was the only thing between the internet and the database. Services in the workspace reach it over the private network, so Flick and the metrics stack are unaffected.Risk
If something outside Render still connects, it is refused after the Blueprint sync. Nothing does today: no workflow uses
DATABASE_URL, the S3 backup in #153 is not built, and local investigation uses a Recovery page download. To undo, revert this PR, or add an entry in the database's Networking settings for immediate access. The Render MCP toolquery_render_postgresstops working for good, because the hosted server connects from an address we do not control. The PR lets the deploy run, because the Blueprint sync must apply the change. The suite is unchanged at 190 passing.How to reach production data now
AGENTS.mdlists the preferred order: remote IEx throughFlick.Repo, then a backup from the Recovery page, then a temporary IP entry forpsql,render psql, or a GUI client. Decision 7 records why there is no standing home IP entry:render.yamlis public, and an entry would publish the address.After merge
psqlwith the external URL from a laptop is refused.Flick.Repo.query!("SELECT 1")works in a remote IEx shell.Worth a reviewer's attention
render.yamlcomment go beyond the issue. The review flagged both as unrequested. I kept the comment because it guards the one line a future editor might delete.render.yamlis unchanged, so the docs say to remove the entry by hand.