Repository navigation
Conversation
Why: The real Windows desktop consumer reached a fully written owner bootstrap file, then failed plugin activation because Node rejects fsync on directory handles with EPERM. Centralize directory durability so Windows skips only that unsupported metadata flush while every file fsync, rename, permission check, and non-Windows I/O error remains enforced. [小太阳·砚砚/gpt-5.6-sol🐾]
Owner
Author
|
Superseded by #167, which landed as d051c45. Its approved exact tree contains the original Windows durability commit 7a4f778 with all eight reviewed source files byte-identical. Exact-head CI 40951084156 passed, and @clowder-ai/collective-connector@0.1.0-alpha.22 is now published with the candidate SHA1 e5bd4cd216a4416658d432b90c0cbcf46b12730a and matching SRI. Closing this source-only PR avoids a duplicate delivery path; native Windows first-activation acceptance remains a separate downstream check and is not claimed here. [小太阳·砚砚/gpt-5.6-sol🐾] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
syncDirectoryhelper.fsynconwin32, where Node returnsEPERM.EPERMafter the bootstrap file itself was durably written, plus a counterexample proving non-Windows I/O errors still propagate.Why
The real Windows desktop consumer failed first activation of
official.collective-connectoratdist/business/service/bootstrap-files.js:69, the directory handle'ssync()call. The file write and file-handlesync()had already completed. CatchingEPERMbroadly would hide real permission or storage failures, so the fix uses the explicit platform contract instead.Test evidence
EPERM; non-WindowsEIOcase already propagated.pnpm --dir packages/collective-connector build— pass.pnpm --dir packages/collective-connector typecheck— pass.pnpm --dir packages/collective-connector test— pass: lifecycle 13, control 62, transport 3, business 438.pnpm --dir packages/collective-connector test:installed— pass: packaged lifecycle/CLI 5.pnpm --dir packages/collective-connector test:source— pass: source/package continuity 4.git diff --check— pass.Boundaries
sync(), atomic rename/link behavior, privacy checks, and non-Windows directory-sync failures remain enforced.bootstrap-files.tsand Service persistence and will need to rebase onto the landed helper; this PR does not change its owner-bootstrap recovery behavior.[小太阳·砚砚/gpt-5.6-sol🐾]