feature: let the api delete Kubernetes nodes of removed game server nodes - #638
Merged
Merged
Conversation
…odes The api cleanup of removed game server nodes deletes their NotReady Node entry, so the api ClusterRole needs the delete verb on nodes.
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Removing a game server node in the panel only deletes its
game_server_nodesrow. The Kubernetes objects the api created for that node stay behind: its update jobs, any game-streamer job that was pinned to it (which keeps its Steam account claimed), its volume claims and volume records, and its NotReady Node entry.Fix
5stackgg/api#471 adds a cleanup for removed nodes. It runs automatically when a node row is deleted, and admins can also start it from Settings > Application > Servers (5stackgg/web#648).
This PR adds the
deleteverb onnodesto the api ClusterRole (server-creator-clusterrole), so the cleanup can also remove the Node entry of a removed node. Jobs and volume claims already havedeletein the namespaced Role, and volume records already havedeletein this ClusterRole.Scope / notes
game_server_nodesrow and has been NotReady for at least 10 minutes. It never deletes a control plane node.git pull && ./update.sh. The in-app Update only restarts the services, so until the script runs, the api keeps getting a 403 on the Node delete.