Conversation
Adds a Danger Zone to Settings > Application > Servers that runs the new cleanupRemovedNodes action and reports what it removed, skipped or could not delete. Remove Node now asks first, since removing a node also starts the cleanup of what it left in Kubernetes.
Flegma
force-pushed
the
feature/node-removal-cleanup
branch
from
October 2, 2026 01:22
408c7e5 to
6c1304b
Compare
Contributor
|
Closing: 5stackgg/api#485 cleans up removed nodes automatically, so the manual cleanup button isn't needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Removing a game server node only deletes its row. The Kubernetes objects the api created for it stay behind: its update, gamedata validation and streamer Jobs, volume claims, volume records and its Node entry. 5stackgg/api#471 cleans them up automatically when a node is removed, but admins need a way to run that cleanup themselves: when the automatic run could not finish, and for nodes removed before that change.
With that change, the one-click Remove Node menu item also starts the cleanup, so it should ask first.
Fix
cleanupRemovedNodesaction and shows the result in a toast: what was removed, whether node entries were kept because the api has no permission to delete nodes, removed nodes that were skipped because Kubernetes reported them as Ready in the last 10 minutes, and how many objects failed. The title says there was nothing to clean up only when nothing was removed, kept or skipped.Scope / notes
git pull && ./update.sh), because the in-app Update does not apply RBAC changes.tests/pages/settings/removedNodeCleanup.spec.tscovers the confirm step, the exact mutation fields, every toast variant, a failed request and the running state.tests/components/game-server-nodes/removeNodeConfirm.spec.tscovers both node menus: Cancel removes nothing, and confirming sendsdelete_game_server_nodes_by_pkonce.yarn testandyarn check-translationspass.