bug: clip fps/resolution are admin-only operator settings - #461
Merged
Merged
Conversation
Moves public.clip_fps/public.clip_resolution back to the unprefixed names (the public. value wins a clash) and deletes stray public.clip_* rows on boot. Every render takes fps and resolution from the operator settings and ignores any a client sends; ClipSpecInput.output is optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clip fps and resolution stay admin-only settings; the api already applies them to every render, so no client needs to read or send them.
1889000000400movespublic.clip_fps/public.clip_resolutionback toclip_fps/clip_resolution(idempotent; thepublic.value wins a clash, it is what the api applied); boot now deletes straypublic.clip_*rowscreateClipFromPreset,queueClipFromPresetandcreateClipRenderignore any client fps/resolution/output and always render at the operator settings;ClipSpecInput.outputis optional, and the old args stay in the schema (ignored) so the deployed web keeps working until the web PR shipsMerge/deploy: merge the api first; the migration runs on boot and the metadata applies with the hasura pod.
Tests: controller clip tests (7) fail on main and pass here; SQL
admin-only-clip-settingscovers up, rerun, clash, 300→400, down, down clash and the boot delete.