Repository navigation
Fix resumed-run approvals and configurable final-response timeouts - #92
Merged
Merged
Conversation
This was referenced Oct 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resuming a historical run could retain
managed=falsein its owner record, so an alive worker rejected approval requests with HTTP 409. Clear the previous generation's management flag and explicitly mark the resumed reservation managed. The HTTP regression tests resume unmanaged records with either attachment state and verify that an approval is accepted on the same run.Add
[run.timeouts] final_responseand--final-response-timeoutto override the closing reply budget. When unset, preserve the existing manager-derived 60–180 second behavior. Timeout and exception regressions verify that a completed audit still produces its full final report even when the reply fails. Unknown config keys remain errors; an invalid budget must not be silently ignored.Correct both READMEs' manager/auditor defaults to 300 seconds and replace the inaccurate native-Windows-support claim with the current limitation, WSL2 workaround, and #70 tracking link. This incorporates the intended small documentation correction from #65 without that branch's unrelated file deletions.
Fixes #83.
Refs #76, #70, #63, #77, #81, #88, #65.
Validation: full Python suite on macOS / Python 3.14.7: 457 passed, 1 skipped (frontend bundle absent). The combined focused regression suite changed from 40 failed / 46 passed on the original main to 86 passed with #85, #82, #75, #71 and this patch. Those four PRs have now been merged; the patch is based on the updated main with those fixes.
git diff --checkpassed. No live provider calls or native Windows end-to-end run was performed.The remaining report-loss cases in #76 still need the reporter's raw reproduction; this PR does not claim to resolve every termination path or add native Windows support.