Skip to content

Fix resumed-run approvals and configurable final-response timeouts - #92

Merged
Upper9527 merged 1 commit into
mainfrom
codex/issue-triage-20261021
Oct 21, 2026
Merged

Upper9527 merged 1 commit into
mainfrom
codex/issue-triage-20261021

Conversation

@Upper9527

Copy link
Copy Markdown
Collaborator

Resuming a historical run could retain managed=false in its owner record, so an alive worker rejected approval requests with HTTP 409. Clear the previous generation's management flag and explicitly mark the resumed reservation managed. The HTTP regression tests resume unmanaged records with either attachment state and verify that an approval is accepted on the same run.

Add [run.timeouts] final_response and --final-response-timeout to override the closing reply budget. When unset, preserve the existing manager-derived 60–180 second behavior. Timeout and exception regressions verify that a completed audit still produces its full final report even when the reply fails. Unknown config keys remain errors; an invalid budget must not be silently ignored.

Correct both READMEs' manager/auditor defaults to 300 seconds and replace the inaccurate native-Windows-support claim with the current limitation, WSL2 workaround, and #70 tracking link. This incorporates the intended small documentation correction from #65 without that branch's unrelated file deletions.

Fixes #83.
Refs #76, #70, #63, #77, #81, #88, #65.

Validation: full Python suite on macOS / Python 3.14.7: 457 passed, 1 skipped (frontend bundle absent). The combined focused regression suite changed from 40 failed / 46 passed on the original main to 86 passed with #85, #82, #75, #71 and this patch. Those four PRs have now been merged; the patch is based on the updated main with those fixes. git diff --check passed. No live provider calls or native Windows end-to-end run was performed.

The remaining report-loss cases in #76 still need the reporter's raw reproduction; this PR does not claim to resolve every termination path or add native Windows support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resumed run retains managed=false and rejects approvals with HTTP 409

1 participant