Repository navigation
Conversation
Carry forward the withdrawn PR #91 with credit to its author. Co-authored-by: Rens Tillmann <feeling4design@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carry forward the focused Windows runtime fix from the author's withdrawn #91. OpenProcess alone reports an exited process alive while another handle retains its kernel object; use pointer-correct ctypes declarations and WaitForSingleObject, and close the handle in finally. Inspection failures remain conservatively alive except a missing PID.
Adds native Windows regression tests and mocked error-path tests. Local macOS run: 7 passed, 4 native cases skipped; Ruff 0.12.2 passes. The prepared Windows CI matrix could not be uploaded because the current token lacks workflow permission. The maintainer chose to defer that authorization; native Windows execution remains a follow-up and is not represented as verified by this PR.
Related to #27: its screenshot specifically shows the older os.kill(pid, 0) implementation, which main has already replaced. This PR adds regression protection and fixes the remaining liveness edge cases, rather than claiming that the screenshot came from this newer implementation.
Original implementation and tests: #91, Rens Tillmann (co-author credit preserved).