Repository navigation
fix: agents don't ask the developer to review, ready, or merge a PR - #73
Merged
Merged
Conversation
… request In the adopting project, agents ended task after task with "review it, mark it ready", "then mark the PR ready; that's your step", or "mark it ready yourself, or ask me to" — /open-pr's report told them to say what the developer should QC before marking it ready, and how to have it promoted. - /open-pr's report gives the URL, that it's a draft, and what was and wasn't verified; it doesn't ask, remind, or offer to review, ready, or merge, and never requests reviewers. A rationalization row and a verification line say so. - AGENTS.md's pull-request rule and git-workflow.md gain the same: when to review, ready, and merge is the developer's. - Fixes the git-workflow bullet the previous commit split: "Check it on the preview too" landed in the middle of "Open as a draft". The ask rules on gh pr ready, merge, and review stay. Decision 0039 records it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This commit was meant for #72, but #72 merged with its earlier head, about four minutes before this commit was pushed to its branch. So it never reached
main, and this pull request lands it.In an adopting project, agents ended task after task with "review it, mark it ready", "then mark the PR ready; that's your step", or "mark it ready yourself, or ask me to".
/open-pr's report step asked them to: it told them to say what the developer should QC before marking the PR ready, and how to have it promoted.What changed
/adf:open-pr's report gives the URL, that it's a draft, and what was and wasn't verified. It doesn't ask, remind, or offer to review, ready, or merge, and never requests reviewers. A rationalization row and a verification line say so.skeleton/AGENTS.md's pull-request rule andgit-workflow.md: when to review, ready, and merge is the developer's.git-workflow.md, the "Check it on the preview too" bullet landed in the middle of "Open as a draft", and carried that bullet's last sentence with it.The ask rules on
gh pr ready,merge, andreviewstay: an agent still never readies, merges, or reviews on its own.Verification
./evals/run-evals.sh: all suites pass, including the two new checks.🤖 Generated with Claude Code