Repository navigation
feat(dev): refuse a project the environment's stack slots can't hold before loading - #479
Merged
Merged
Conversation
Contributor
[Medium impact] The PR appears safe to merge; the previously reported test failure is fixed. SummaryAdds a stack-slot check before
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
adiman9
force-pushed
the
feat/dev-up-quota-preflight
branch
from
October 29, 2026 04:27
605005f to
398a57d
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #475 (
feat/dev-edge), which loadsarete.lockstacks ina4 dev up.a4 dev upchecks the environment's stack slots before it loads anything. A project whose stacks don't fit is refused with every stack named, the slots each needs, the dev tier and how to raise it; nothing is loaded.What changed
cli/src/commands/dev/quotas.rs: readsGET /api/dev/quotas(limits.maxStacksPerEnvironment,tier) and the environment's stack listing, then plans what this run loads: every registry stackarete.lockpins (lock_stacks, one per live alias), the protocol's generated stack and the project's own stacks. Stacks the environment already holds cost no slot: a registry package's aliases count as loaded up to the deployments the environment holds for it, an authored StackManifest is expanded into one stack per live alias (asa4 dev updeploys them) and matched by name, and the protocol stack by slug. An API that reports no limit skips the check.start()inup.rs, before the protocol deploy,load_lock_stacksanddeploy_project_stacks.a4 doctor'saccount.dev-environmentsadds "N stacks per environment" when the API reports it.Tests
a_project_over_the_free_tier_is_refused_with_every_stack_named,lock_stacks_count_before_any_loads(free tier, one slot left, three lock stacks of which one is loaded: refused naming each),stacks_that_fit_or_reload_pass,the_plan_matches_loaded_stacks_by_name_and_protocol; doctor detail with stack slots.Notes