Skip to content

ci: run CI and publish on Node 24 - #488

Merged
VickyXAI merged 1 commit into
mainfrom
ci/node-24
Oct 20, 2026
Merged

VickyXAI merged 1 commit into
mainfrom
ci/node-24

Conversation

@VickyXAI

@VickyXAI VickyXAI commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Dependabot #486 bumps the openclaw devDependency to 2026.10.4. That version refuses to install below Node 24.16 ([openclaw] error: this OpenClaw release requires Node >=24.16.0), so npm ci fails on the Node 22 runners and every check goes red before any test runs.

Changes:

Users can still install on Node 22: engines stays >=22 and openclaw is dev-only. Dockerfile.install-test and the pinned openclaw-2026.5 image stay on Node 22 to keep covering that path.

I ran the full set of CI steps locally on Node 24.19.0: prettier, eslint, typecheck and build are clean, and the tests are 1219 passed, 1 skipped.

Summary by CodeRabbit

  • Chores
    • Updated automated validation, publishing, and test environments to use Node.js 24.
    • Improved compatibility with development tooling requiring Node.js 24.16 or later.
    • Continued coverage for Node.js 22 through separate installation tests.

openclaw 2026.10+ (the devDependency Dependabot #486 bumps to) refuses to
install below Node 24.16, so npm ci fails on the Node 22 runners and every
check goes red before a test runs. Move the lint, build/test and publish jobs
to Node 24, plus the Docker images that install openclaw@latest (the scanner
image among them). engines stays >=22: openclaw is dev-only, and
Dockerfile.install-test and the pinned openclaw-2026.5 image still cover a
Node 22 user install.
@coderabbitai

coderabbitai Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

📝 Walkthrough

CI, publishing, and test Docker images now use Node 24 instead of Node 22. The CI workflow documents that the openclaw development dependency requires Node 24.16 or later.

Changes: Node 24 runtime update

Layer / File(s) Summary
Select Node 24 across workflows and test images
.github/workflows/ci.yml, .github/workflows/publish.yml, test/Dockerfile.test, test/docker/Dockerfile.edge-cases, test/integration/Dockerfile
The CI and publishing workflows and test Docker images now use Node 24. The CI workflow documents the openclaw development dependency's Node 24.16 minimum.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: achiurizo

Merge Risk: ⚪ Minimal · up to 58313

No merge-blocking risk is established by the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating CI and publishing workflows to use Node 24.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (5 skipped: 5 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔇 Additional comments: 5
.github/workflows/ci.yml: 1

21-24: LGTM!

Also applies to: 27-27, 49-49

.github/workflows/publish.yml: 1

33-33: LGTM!

test/Dockerfile.test: 1

1-1: LGTM!

test/docker/Dockerfile.edge-cases: 1

2-2: LGTM!

test/integration/Dockerfile-1-1: 1

1-1: 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win

⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Run the integration image as a non-root user.

This Dockerfile has no USER instruction, so the integration test command runs as root. Create an unprivileged user after the root-only setup, adjust ownership of writable paths, and set USER before CMD.

Source: Linters/SAST tools


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository: BlockRunAI/ClawRouter/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 13210ad8-04d2-4c34-9b29-e41e307c3468
📥 Commits

Reviewing files that changed from the base of the PR and between db8a9fc and 5831310.

📒 Files selected for processing: 5
  • .github/workflows/ci.yml
  • .github/workflows/publish.yml
  • test/Dockerfile.test
  • test/docker/Dockerfile.edge-cases
  • test/integration/Dockerfile

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

@VickyXAI
VickyXAI merged commit 35fb714 into main Oct 20, 2026
5 checks passed
@VickyXAI
VickyXAI deleted the ci/node-24 branch October 20, 2026 05:00
VickyXAI pushed a commit that referenced this pull request Oct 20, 2026
DeepSeek V4.1 Flash added; free v4-flash pins follow the free default (#487).
Catalog synced to the live gateway: six chat models, grok-imagine-video-1.5,
retired ids follow the gateway redirect (#485). CI and publish on Node 24
(#488), scanner test reads .mjs chunks (#490), tsup 9 / vitest 5 (#486).
dist/ rebuilt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant