Repository navigation
ci: run CI and publish on Node 24 - #488
Conversation
openclaw 2026.10+ (the devDependency Dependabot #486 bumps to) refuses to install below Node 24.16, so npm ci fails on the Node 22 runners and every check goes red before a test runs. Move the lint, build/test and publish jobs to Node 24, plus the Docker images that install openclaw@latest (the scanner image among them). engines stays >=22: openclaw is dev-only, and Dockerfile.install-test and the pinned openclaw-2026.5 image still cover a Node 22 user install.
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
There was a problem hiding this comment.
🔇 Additional comments: 5
.github/workflows/ci.yml: 1
21-24: LGTM!Also applies to: 27-27, 49-49
.github/workflows/publish.yml: 1
33-33: LGTM!test/Dockerfile.test: 1
1-1: LGTM!test/docker/Dockerfile.edge-cases: 1
2-2: LGTM!test/integration/Dockerfile-1-1: 1
1-1: 🔒 Security & Privacy | 🟡 Minor | ⚡ Quick win
⚠️ Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.Run the integration image as a non-root user.
This Dockerfile has no
USERinstruction, so the integration test command runs asroot. Create an unprivileged user after the root-only setup, adjust ownership of writable paths, and setUSERbeforeCMD.Source: Linters/SAST tools
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: BlockRunAI/ClawRouter/.coderabbit.yaml
- Review profile: CHILL
- Plan: Advanced
- Run ID:
13210ad8-04d2-4c34-9b29-e41e307c3468
📒 Files selected for processing: 5
.github/workflows/ci.yml.github/workflows/publish.ymltest/Dockerfile.testtest/docker/Dockerfile.edge-casestest/integration/Dockerfile
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.
DeepSeek V4.1 Flash added; free v4-flash pins follow the free default (#487). Catalog synced to the live gateway: six chat models, grok-imagine-video-1.5, retired ids follow the gateway redirect (#485). CI and publish on Node 24 (#488), scanner test reads .mjs chunks (#490), tsup 9 / vitest 5 (#486). dist/ rebuilt.
Dependabot #486 bumps the
openclawdevDependency to 2026.10.4. That version refuses to install below Node 24.16 ([openclaw] error: this OpenClaw release requires Node >=24.16.0), sonpm cifails on the Node 22 runners and every check goes red before any test runs.Changes:
ci.yml: Lint & Typecheck and Build & Test move to Node 24. Desktop was already on 24.publish.yml: Node 24, so releases keep publishing once build(deps-dev): bump the dev-dependencies group across 1 directory with 7 updates #486 lands.test/integration/Dockerfile(the scanner image),test/Dockerfile.testandtest/docker/Dockerfile.edge-casesmove tonode:24-slim, because they installopenclaw@latest.Users can still install on Node 22:
enginesstays>=22and openclaw is dev-only.Dockerfile.install-testand the pinnedopenclaw-2026.5image stay on Node 22 to keep covering that path.I ran the full set of CI steps locally on Node 24.19.0: prettier, eslint, typecheck and build are clean, and the tests are 1219 passed, 1 skipped.
Summary by CodeRabbit