Skip to content

fix(contrast-master): correct normal and large text font size thresholds per WCAG SC 1.4.3 - #214

Open
AdamMagued wants to merge 1 commit into
Community-Access:mainfrom
AdamMagued:fix/contrast-text-sizing-wcag
Open

AdamMagued wants to merge 1 commit into
Community-Access:mainfrom
AdamMagued:fix/contrast-text-sizing-wcag

Conversation

@AdamMagued

Copy link
Copy Markdown

Resolves #198

Why This Change is Needed

In skills/contrast-master/SKILL.md (and associated references), text size thresholds for WCAG AA contrast were incorrectly defined using pixels:

  • Normal text: (under 18px or under 14px bold)
  • Large text: (18px+ or 14px+ bold)

This conflated typographical points (pt) with CSS pixels (px). WCAG 2.1 and 2.2 Success Criterion 1.4.3 Contrast (Minimum) defines:

  • Large text: at least 18pt regular or 14pt bold.
  • Normal text: anything smaller than 18pt regular or 14pt bold.

Per the WCAG SC 1.4.3 specification regarding CSS pixel conversion (1pt = 1.333px):

  • 18pt corresponds to 24px (or 24px+).
  • 14pt bold corresponds to approximately 18.5px bold (18.67px).

What Changes Were Made

  1. skills/contrast-master/SKILL.md:
    • Updated normal text threshold to under 18pt / 24px, or under 14pt / 18.5px bold for 4.5:1 contrast.
    • Updated large text threshold to at least 18pt / 24px, or at least 14pt / 18.5px bold for 3:1 contrast.
    • Added explanatory guidance citing the WCAG SC 1.4.3 definition and CSS pixel conversion (1pt = 1.333px).
  2. docs/reference/skills/contrast-master.md:
    • Clarified large text criteria with point and pixel equivalents (3:1 for large text: at least 18pt / 24px, or at least 14pt / 18.5px bold).
  3. skills/contrast-master/references/validation-checklist.md:
    • Updated item 1 to specify (or 3:1 for large text: at least 18pt / 24px, or 14pt / 18.5px bold).

Verification

  • Ran npm run verify in the test sandbox: all 15 gates passed with 0 failures.
    • Agent Skills specification: PASS (108 skills conformant)
    • Package rules: PASS (108 skills validated)
    • Frontmatter conformance: PASS
    • Context budgets: PASS
    • Findings contract: PASS (88 passed, 0 failed)
    • Report renderer: PASS
    • Enforcement gate: PASS (22 passed, 0 failed)
    • MCP server: PASS (107 passed, 0 failed)
    • Markdown accessibility: PASS
    • Markdown linter: PASS (21 passed, 0 failed)
    • Version consistency: PASS
    • Dispatch matrices: PASS
    • Generated documentation: PASS
    • Dependency advisories: PASS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Normal text and large text sizing values are incorrect based on WCAG SC 1.4.3 definition

1 participant