Conversation
fLastKnownLatency starts at 0 and nothing updates it on activation, so a plugin that sets a nonzero latency in activate() has a latency change reported as soon as it runs. Recording the latency in activate(), where the host reads it, prevents that. This was tested on Linux with a plugin that sets its latency in activate(). Bitwig logged "plugin reported latency change while activated" when the plugin loaded, and clap-validator 0.4.1 showed 19 failed tests with "Must only be called within 'clap_plugin::activate'". This commit resolves both. Fixes DISTRHO#541. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fLastKnownLatency starts at 0 and nothing updates it on activation, so a plugin that sets a nonzero latency in activate() has a latency change reported as soon as it runs. Recording the latency in activate(), where the host reads it, prevents that.
This was tested on Linux with a plugin that sets its latency in activate(). Bitwig logged "plugin reported latency change while activated" when the plugin loaded, and clap-validator 0.4.1 showed 19 failed tests with "Must only be called within 'clap_plugin::activate'". This commit resolves both.
Fixes #541.
As with the issue I filed, I drafted this with help from an AI assistant and tested it myself. Please let me know if that's unwelcome, and I will close the issue and PR, and refrain from it in the future.
🤖 Generated with Claude Code