Skip to content

Update compatibility matrix - #178

Merged
DanSheps merged 4 commits into
mainfrom
update-compat
Oct 19, 2026
Merged

DanSheps merged 4 commits into
mainfrom
update-compat

Conversation

@DanSheps

Copy link
Copy Markdown
Owner

Update compatibility matrix

  • Update version
  • Update Compat Matrix
  • Update init.py min version

@DanSheps
DanSheps merged commit 4d67a23 into main Oct 19, 2026
1 check passed
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Raise NetBox minimum to 4.7 and refresh compatibility data

⚙️ Configuration changes 📝 Documentation 🧪 Tests 🕐 10-20 Minutes

Grey Divider

AI Description

• Require NetBox 4.7 and bump the plugin release to 1.1.11.
• Add NetBox 4.7 to the compatibility matrix.
• Lower API list-view query-count baselines across seven model types.
Diagram

graph TD
  Package["Package 1.1.11"] --> Plugin["Plugin minimum 4.7"] --> NetBox["NetBox 4.7"] --> Tests["List-view tests"] --> Counts["Query baselines"]
  Matrix["Compatibility matrix"] --> NetBox
Loading
High-Level Assessment

Updating the existing version declaration, plugin minimum, matrix, and test baselines directly is appropriate; no architectural alternative is warranted. Before merging, reconcile the README requirement of “NetBox 4.5 or later” with the new 4.7 minimum, and confirm why the 4.7.x matrix entry names 1.1.10 rather than the newly declared 1.1.11.

Files changed (4) +18 / -17

Tests (1) +14 / -14
query_counts.jsonRevise list-view query-count expectations +14/-14

Revise list-view query-count expectations

• Lowers API list-object expectations by one query and permission-aware list expectations by three queries for each of seven model types.

netbox_lifecycle/tests/query_counts.json

Documentation (1) +1 / -0
README.mdDocument NetBox 4.7 compatibility +1/-0

Document NetBox 4.7 compatibility

• Adds a matrix row pairing NetBox 4.7.x with plugin 1.1.10. The separate requirements section still says NetBox 4.5 or later.

README.md

Other (2) +3 / -3
__init__.pyRequire NetBox 4.7.0 +1/-1

Require NetBox 4.7.0

• Raises the plugin configuration's minimum NetBox version from 4.5.0 to 4.7.0.

netbox_lifecycle/init.py

pyproject.tomlBump package version to 1.1.11 +2/-2

Bump package version to 1.1.11

• Changes the declared package version from 1.1.10 to 1.1.11. Also adds a final newline.

pyproject.toml

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Grey Divider


Action required

1. NetBox 4.5 upgrades fail at startup 🐞 Bug ≡ Correctness
Description
NetBoxLifeCycle.min_version now requires 4.7.0, but the README still instructs NetBox 4.5 and 4.6
users to install or upgrade the package without a version pin. When those users receive 1.1.11,
NetBox rejects the plugin on load; the package dependencies do not prevent that installation.
Code

netbox_lifecycle/init.py[16]

+    min_version = '4.7.0'
Evidence
The plugin's new minimum is 4.7.0, while the README lists NetBox 4.5 and 4.6 compatibility and gives
both unpinned installation and upgrade commands. The package declares no NetBox version constraint
that would stop pip from selecting the new release.

netbox_lifecycle/init.py[8-16]
README.md[14-29]
README.md[35-40]
README.md[69-75]
pyproject.toml[28-30]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
Unpinned installation and upgrade commands can install 1.1.11 on NetBox 4.5 or 4.6, where the new minimum version prevents the plugin from loading.
## Fix Focus Areas
- README.md[14-16]
- README.md[24-29]
- README.md[35-40]
- README.md[69-75]
## Recommended Fix
Clarify that the latest release requires NetBox 4.7 and provide version-pinned installation and upgrade instructions for older supported NetBox versions.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Compliance rules (platform): 5 rules
Review mode: Auto: ⚖️ Balanced: Version compatibility changes affect runtime support and require careful consistency review.

Grey Divider

Tip of the day
💡 Did you know, you can import rules and skills only from the repositories your team follows

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

author_email = metadata.get('Author-email')
base_url = 'lifecycle'
min_version = '4.5.0'
min_version = '4.7.0'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Netbox 4.5 upgrades fail at startup 🐞 Bug ≡ Correctness

NetBoxLifeCycle.min_version now requires 4.7.0, but the README still instructs NetBox 4.5 and 4.6
users to install or upgrade the package without a version pin. When those users receive 1.1.11,
NetBox rejects the plugin on load; the package dependencies do not prevent that installation.
Agent Prompt
## Issue description
Unpinned installation and upgrade commands can install 1.1.11 on NetBox 4.5 or 4.6, where the new minimum version prevents the plugin from loading.
## Fix Focus Areas
- README.md[14-16]
- README.md[24-29]
- README.md[35-40]
- README.md[69-75]
## Recommended Fix
Clarify that the latest release requires NetBox 4.7 and provide version-pinned installation and upgrade instructions for older supported NetBox versions.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

@DanSheps
DanSheps deleted the update-compat branch October 19, 2026 16:04

This branch was successfully deployed

1 active deployment
build — 58a368e9 Deployed Oct 19, 2026 by DanSheps via Build Distribution #327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant