Skip to content

Update compatibility matrix #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanSheps merged 4 commits into from
Oct 19, 2026
Merged

Update compatibility matrix #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ab0428
Update compat
DanSheps Oct 19, 2026
7d43a2b
Modify query counts in query_counts.json
DanSheps Oct 19, 2026
2b44b9b
Update minimum version requirement to 4.7.0
DanSheps Oct 19, 2026
58a368e
Bump version from 1.1.10 to 1.1.11
DanSheps Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ The NetBox Lifecycle plugin adds hardware EOS/EOL, license and support contract
| 4.4.x | 1.1.6 |
| 4.5.x | 1.1.8 |
| 4.6.x | 1.1.9 |
| 4.7.x | 1.1.10 |

## Installation

Expand Down
2 changes: 1 addition & 1 deletion netbox_lifecycle/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class NetBoxLifeCycle(PluginConfig):
author = metadata.get('Author')
author_email = metadata.get('Author-email')
base_url = 'lifecycle'
min_version = '4.5.0'
min_version = '4.7.0'

@qodo-code-review qodo-code-review Bot Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Netbox 4.5 upgrades fail at startup 🐞 Bug ≡ Correctness

NetBoxLifeCycle.min_version now requires 4.7.0, but the README still instructs NetBox 4.5 and 4.6
users to install or upgrade the package without a version pin. When those users receive 1.1.11,
NetBox rejects the plugin on load; the package dependencies do not prevent that installation.
Agent Prompt 
## Issue description
Unpinned installation and upgrade commands can install 1.1.11 on NetBox 4.5 or 4.6, where the new minimum version prevents the plugin from loading.
## Fix Focus Areas
- README.md[14-16]
- README.md[24-29]
- README.md[35-40]
- README.md[69-75]
## Recommended Fix
Clarify that the latest release requires NetBox 4.7 and provide version-pinned installation and upgrade instructions for older supported NetBox versions.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗

required_settings = []
default_settings = {
'lifecycle_card_position': 'right_page',
Expand Down
28 changes: 14 additions & 14 deletions netbox_lifecycle/tests/query_counts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
{
"hardwarelifecycle:api_list_objects": 16,
"hardwarelifecycle:list_objects_with_permission": 22,
"license:api_list_objects": 14,
"license:list_objects_with_permission": 20,
"licenseassignment:api_list_objects": 16,
"licenseassignment:list_objects_with_permission": 23,
"supportcontract:api_list_objects": 14,
"supportcontract:list_objects_with_permission": 20,
"supportcontractassignment:api_list_objects": 18,
"supportcontractassignment:list_objects_with_permission": 26,
"supportsku:api_list_objects": 14,
"supportsku:list_objects_with_permission": 21,
"vendor:api_list_objects": 13,
"vendor:list_objects_with_permission": 20
"hardwarelifecycle:api_list_objects": 15,
"hardwarelifecycle:list_objects_with_permission": 19,
"license:api_list_objects": 13,
"license:list_objects_with_permission": 17,
"licenseassignment:api_list_objects": 15,
"licenseassignment:list_objects_with_permission": 20,
"supportcontract:api_list_objects": 13,
"supportcontract:list_objects_with_permission": 17,
"supportcontractassignment:api_list_objects": 17,
"supportcontractassignment:list_objects_with_permission": 23,
"supportsku:api_list_objects": 13,
"supportsku:list_objects_with_permission": 18,
"vendor:api_list_objects": 12,
"vendor:list_objects_with_permission": 17
}
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ description = "NetBox Support Contract and EOL/EOS management"
readme = "README.md"
requires-python = ">=3.12"
keywords = ["netbox-plugin", ]
version = "1.1.10"
version = "1.1.11"
license = { file = "LICENSE" }
classifiers = [
"Programming Language :: Python :: 3",
Expand All @@ -40,4 +40,4 @@ extend-exclude = '''
/(
| netbox_lifecycle/migrations
)/
'''
'''
Loading