Repository navigation
Conversation
geonnave
force-pushed
the
spin-place-to-calibration
branch
from
October 15, 2026 11:26
b9dfc55 to
80292e3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #344 +/- ##
=======================================
Coverage 88.56% 88.56%
=======================================
Files 230 230
Lines 37623 37623
Branches 2367 2368 +1
=======================================
Hits 33319 33319
Misses 4300 4300
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
geonnave
force-pushed
the
spin-place-to-calibration
branch
5 times, most recently
from
October 16, 2026 14:07
2d8ddf5 to
62ebd24
Compare
AI-assisted: Claude Opus 5.5
… a placed one AI-assisted: Claude Opus 5.5
…red station AI-assisted: Claude Opus 5.5
AI-assisted: Claude Opus 5.5
geonnave
force-pushed
the
spin-place-to-calibration
branch
from
October 16, 2026 14:38
62ebd24 to
8aeadc9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #343 (
spin-append-placed-hintat 9ddf837, itself based on main), for theplaced_fromfield. Review the top two commits.Problem
Strengthening a site's spin calibration means collecting more rounds in a free frame (in the site the spins were first collected in), then moving the result onto the site already in use, through a station both calibrations solved. That move was done with a scratch script: fit the turn and shift that map the new calibration's station-0 circle centres onto the old calibration's, apply it to every station, write the file.
Change
dotbot swarm calibrate-lh2 place SOURCE --to-calibration TARGET [--station N ...] [--tag T]placed_from= SOURCE, tag<source tag>-<site>unless--tag.--stationnot in both, fewer than 3 circles. With several shared stations--stationis required rather than picking all of them: a weakly tied station in TARGET would pull the fit, which is usually the reason for re-collecting in the first place.Naming:
placeis the word the site editor uses for moving a spin calibration onto a site (#326),--to-calibrationmirrorssite init --from-calibration, and--stationtakes an index like--drop-station. It lives underswarm calibrate-lh2besideshowandreframe, which also only read and write files, and like them refusesdotbot swarm -d. #326'splace_calibrationdoes the same move from the console with a hand-set transform; once both land, the two can share one mover.Validation
site init, a second free-frame one from other robots,placethrough station 0: residual under 1 mm rms, a non-trivial move, and both stations then put every floor point in the overlap within 2 mm of the target's. Refusals covered too. Full suite: 1791 passed, the same 2 environment failures as on the base.place 05aea267 --to-calibration 04707621 --station 0gives turn 89.216 deg, shift (3105.0, 2029.6) mm, 9 circles, rms 2.99 mm, max 6.07 mm, the same move as the script that produced e0897cfb. The homographies agree with e0897cfb to 1e-12; the id differs only through those last float bits. Through both stations the rms is 9.35 mm, which is why--stationis required.dotbot/calibration/conics.pydotbot/tests/test_calibration_spin.pydotbot/cli/swarm_lh2.py